From 37dc743591dee0e4326d0100a41f725d4704faf3 Mon Sep 17 00:00:00 2001 From: geronimo Date: Thu, 26 Jul 2012 17:17:09 +0200 Subject: fixed bug around enum/int confusion --- cmpcj/src/de/schwarzrot/cmpc/util/MediaComparator.java | 2 +- .../src/de/schwarzrot/cmpc/util/MediaForTypeMatcher.java | 6 +++--- cmpcj/src/de/schwarzrot/cmpc/util/MediaPool2TypeList.java | 5 +++-- cmpcj/src/de/schwarzrot/cmpc/util/MediaTypeSelect.java | 15 ++++++++------- 4 files changed, 15 insertions(+), 13 deletions(-) (limited to 'cmpcj/src/de/schwarzrot/cmpc/util') diff --git a/cmpcj/src/de/schwarzrot/cmpc/util/MediaComparator.java b/cmpcj/src/de/schwarzrot/cmpc/util/MediaComparator.java index 8e9ce48..a719032 100644 --- a/cmpcj/src/de/schwarzrot/cmpc/util/MediaComparator.java +++ b/cmpcj/src/de/schwarzrot/cmpc/util/MediaComparator.java @@ -35,6 +35,6 @@ public class MediaComparator implements Comparator { public int compare(Media a, Media b) { if (a.getType() == b.getType()) return a.getName().compareToIgnoreCase(b.getName()); - return a.getType() - b.getType(); + return a.getType().ordinal() - b.getType().ordinal(); } } diff --git a/cmpcj/src/de/schwarzrot/cmpc/util/MediaForTypeMatcher.java b/cmpcj/src/de/schwarzrot/cmpc/util/MediaForTypeMatcher.java index c3a3469..18820cf 100644 --- a/cmpcj/src/de/schwarzrot/cmpc/util/MediaForTypeMatcher.java +++ b/cmpcj/src/de/schwarzrot/cmpc/util/MediaForTypeMatcher.java @@ -34,7 +34,7 @@ import de.schwarzrot.cmpc.domain.Media; public class MediaForTypeMatcher implements Matcher { - public MediaForTypeMatcher(Collection mediaTypes) { + public MediaForTypeMatcher(Collection mediaTypes) { this.mediaTypes.addAll(mediaTypes); } @@ -45,10 +45,10 @@ public class MediaForTypeMatcher implements Matcher { return false; if (mediaTypes.isEmpty()) return true; - Integer mt = m.getType(); + Media.SupportedMediaType mt = m.getType(); return mediaTypes.contains(mt); } - private Set mediaTypes = new HashSet(); + private Set mediaTypes = new HashSet(); } diff --git a/cmpcj/src/de/schwarzrot/cmpc/util/MediaPool2TypeList.java b/cmpcj/src/de/schwarzrot/cmpc/util/MediaPool2TypeList.java index ce541ac..de93246 100644 --- a/cmpcj/src/de/schwarzrot/cmpc/util/MediaPool2TypeList.java +++ b/cmpcj/src/de/schwarzrot/cmpc/util/MediaPool2TypeList.java @@ -32,7 +32,7 @@ import ca.odell.glazedlists.event.ListEvent; import de.schwarzrot.cmpc.domain.Media; -public class MediaPool2TypeList extends TransformedList { +public class MediaPool2TypeList extends TransformedList { public MediaPool2TypeList(EventList source) { super(source); source.addListEventListener(this); @@ -40,13 +40,14 @@ public class MediaPool2TypeList extends TransformedList { @Override - public Integer get(int index) { + public Media.SupportedMediaType get(int index) { Media m = source.get(index); return m.getType(); } + @Override public void listChanged(ListEvent listChanges) { updates.forwardEvent(listChanges); } diff --git a/cmpcj/src/de/schwarzrot/cmpc/util/MediaTypeSelect.java b/cmpcj/src/de/schwarzrot/cmpc/util/MediaTypeSelect.java index 9ba948e..033ee53 100644 --- a/cmpcj/src/de/schwarzrot/cmpc/util/MediaTypeSelect.java +++ b/cmpcj/src/de/schwarzrot/cmpc/util/MediaTypeSelect.java @@ -67,7 +67,7 @@ public class MediaTypeSelect extends AbstractMatcherEditor implements Lis setBackground(list.getBackground()); setForeground(list.getForeground()); } - ImageIcon icon = images[(Integer) value]; + ImageIcon icon = images[((Media.SupportedMediaType) value).ordinal()]; setSize(110, 110); setHorizontalAlignment(JLabel.CENTER); @@ -105,13 +105,14 @@ public class MediaTypeSelect extends AbstractMatcherEditor implements Lis public MediaTypeSelect(EventList source) { - EventList mediaTypeNonUnique = new MediaPool2TypeList(source); + EventList mediaTypeNonUnique = new MediaPool2TypeList(source); - mediaTypeList = new UniqueList(mediaTypeNonUnique); - DefaultEventListModel mediaTypeListModel = new DefaultEventListModel(mediaTypeList); + mediaTypeList = new UniqueList(mediaTypeNonUnique); + DefaultEventListModel mediaTypeListModel = new DefaultEventListModel( + mediaTypeList); mediaTypeJList = new JList(mediaTypeListModel); - DefaultEventSelectionModel mediaTypeSelectionModel = new DefaultEventSelectionModel( + DefaultEventSelectionModel mediaTypeSelectionModel = new DefaultEventSelectionModel( mediaTypeList); mediaTypeJList.setSelectionModel(mediaTypeSelectionModel); @@ -134,8 +135,8 @@ public class MediaTypeSelect extends AbstractMatcherEditor implements Lis fireChanged(newMatcher); } - private EventList mediaTypeList; - private EventList selectedTypes; + private EventList mediaTypeList; + private EventList selectedTypes; private JList mediaTypeJList; private static final String[] iconFiles; static { -- cgit v1.2.3