diff options
Diffstat (limited to 'README.patches')
| -rw-r--r-- | README.patches | 22 |
1 files changed, 15 insertions, 7 deletions
diff --git a/README.patches b/README.patches index ea69fd2c0..90ae313d8 100644 --- a/README.patches +++ b/README.patches @@ -206,7 +206,15 @@ e) Although not documented at kernel's Documentation/, a common kernel inserted at master repository. In this case, the ack will be added only at -git tree. -f) If the patch also affects other parts of kernel (like Alsa +f) Another kernel's practice that is agreed to be good is that a + patchset should be reviewed/tested by other developers. So, a new + tag should be used by testers/reviewers. So, reviewers are welcome. + After reviewing a patchset, please send an e-mail indicating that, if + possible, with some additional data about the testing, with the tag: + Reviewed-by: My Name <myemail@mysite.com> + This is particulary important for Kernel to userspace ABI changes. + +g) If the patch also affects other parts of kernel (like Alsa or i2c), it is required that, when submitting upstream, the patch also goes to the maintainers of that subsystem. To do this, the developer shall copy the interested parties. @@ -229,7 +237,7 @@ f) If the patch also affects other parts of kernel (like Alsa for their acks, then commit to the development tree or send the patch via email with their Acked-by: already included. -g) Sometimes, mainstream changes affect the v4l-dvb tree, and mast be +h) Sometimes, mainstream changes affect the v4l-dvb tree, and mast be backported to the v4l-dvb tree. This kind of commit to the mercurial tree should follow the rules above and should also have the line: @@ -237,7 +245,7 @@ g) Sometimes, mainstream changes affect the v4l-dvb tree, and mast be Patches with this line will not be submitted upstream. -h) Sometimes it is necessary to introduce some testing code inside a +i) Sometimes it is necessary to introduce some testing code inside a module or remove parts that are not yet finished. Also, compatibility tests may be required to provide backporting. @@ -286,7 +294,7 @@ should be included at the See the file v4l/scripts/gentree.pl for a more complete description of what kind of code will be kept and what kind will be removed. -i) To import contributed stuff to a developer's, a script is provided. +j) To import contributed stuff to a developer's, a script is provided. This allows an easy import of mbox-based patch emails. This is done with (called from the root tree directory): @@ -303,7 +311,7 @@ i) To import contributed stuff to a developer's, a script is provided. that can be applied/unapplied for testing. mailimport trusts on it to work, so, this extension should be enabled for mailimport script to work. -j) By submitting a patch to the subsystem maintainer, either via email +k) By submitting a patch to the subsystem maintainer, either via email or via pull request, the patch author(s) are agreeing that the submitted code will be added on Kernel, and that the submitted code are being released as GPLv2. The author may grant additional licenses @@ -347,8 +355,8 @@ There's a delay between updating a patch at master and sending it to mainstream. During this period, it is possible to review a patch. The common situations are: -1) If a patch at master tree receives an Acked-by:, this can be added at --git tree; +1) If a patch at master tree receives a late Acked-by: or a +Reviewed-by:, this can be added at -git tree; 2) If somebody fully nacks a patch applied at -hg, A reverse patch can be applied at -hg, and the original patch can be removed -git; |