summaryrefslogtreecommitdiff
path: root/linux/drivers/media/video/bttv-risc.c
AgeCommit message (Collapse)Author
2006-03-13BUG_ON() Conversion in drivers/video/mediaMauro Carvalho Chehab
From: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-03-09Nskips maybe used uninitialized in bttv_risc_overlayMauro Carvalho Chehab
The Coverity checker (previously Stanford checker) noticed that the value of nskips could be read even if it was never written. Signed-off-by: Duncan Sands <baldrick@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-02-26bttv: correct bttv_risc_packed buffer sizeMauro Carvalho Chehab
From: Duncan Sands <duncan.sands@math.u-psud.fr> This patch fixes the strange crashes I was seeing after using bttv card, caused by a buffer overflow in bttv_risc_packed. The instruction buffer size calculation contains two errors: (a) a non-zero padding value can push the start of the next bpl section to just before a page border, leading to more scanline splits and thus additional instructions. (b) the first DMA region can be smaller than one page, so there can be a scanline split even if bpl*lines is smaller than PAGE_SIZE. For example, consider the case where offset is 0, bpl is 2, padding is 4094, lines is smaller than 2048, the first DMA region has size 1 and all others have size PAGE_SIZE, assumed to equal 4096. Then all bpl regions cross page borders and the number of instructions written is 2*lines+2, rather than lines+2 (the current estimate). With this patch the number of instructions for this example is estimated to be 2*lines+3. Also, the BUG_ON that was supposed to catch buffer overflows contained a thinko causing it fire only if the buffer was overrun by a factor of 16 or more, so it fixes the the BUG_ON's (using sizeof rather than "4"). Signed-off-by: Duncan Sands <baldrick@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2005-10-16- Whitespaces Cleanups.Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
2005-10-16- Whitespace Cleanups.Mauro Carvalho Chehab
- Whitespace script improved. Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
2004-11-19- misc cleanups.Gerd Knorr
- blackbird + empress updates.
2004-10-13- kill trailing whitespaces.Gerd Knorr
2004-10-06- bttv: irq fixes.Gerd Knorr
- add i2c scans.
2004-09-16- bttv: fix planat capture.Gerd Knorr
- bttv: add risc buffer size sanity checks.
2004-09-15- added a bunch of $Id$ tags.Gerd Knorr
2004-09-15- bttv: fix planar capture oops.Gerd Knorr
- cx88: make dvb driver quiet. - cx88: some i2c init/exit fixes.
2004-08-23- some bttv debug code.Gerd Knorr
- new tuner type by Michael T. Dean
2004-07-06- bttv: finetune chroma lines used for yuv planar modes (based on patchGerd Knorr
by Michael Niedermayer).
2004-04-13- bttv: splitted video + vbi buffer switching, that should make bttvGerd Knorr
less sensitive to IRQ latencies. - saa7134: new card added, minor saa7133 fixes (by toshii@netbsd.org).
2004-02-22Initial revisionGerd Knorr