summaryrefslogtreecommitdiff
path: root/linux/drivers/media/video/cx231xx/cx231xx-video.c
AgeCommit message (Collapse)Author
2009-07-02Remove unnecessary semicolonsDouglas Schilling Landgraf
From: Joe Perches <joe@perches.com> Priority: normal Signed-off-by: Joe Perches <joe@perches.com> CC: Patrick Boettcher <patrick.boettcher@desy.de> CC: Steven Toth <stoth@linuxtv.org> CC: Igor M. Liplianin <liplianin@netup.ru> CC: Srinivasa Deevi <srinivasa.deevi@conexant.com> Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
2009-05-30cx231xx: TRY_FMT should not actually set anythingTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> In the TRY_FMT handler the function get_scale() is called to find what the scaler hardware will produce for a requested size. The problem is that get_scale(struct cx231xx *dev, ..., unsigned int *vscale, unsigned int *hscale) saves the calculated scale values into both the pointer arguments and into dev's hscale and vscale fields. TRY_FMT shouldn't actually change anything in the device state. The code to in get_scale() that writes to dev->[hv]scale can just be deleted. In all cases when dev's fields should be modified, get_scale() was called with get_scale(dev, ..., &dev->hscale, &dev->vscale), so dev was getting updated anyway. This didn't actually cause a problem because nothing ever actually made use of the hscale and vscale fields. I changed cx231xx_resolution_set() to use those fields rather than re-calculate them with a call to get_scale(). Updating [hv]scale in cx231xx_resolution_set() isn't necessary because every call of cx231xx_resolution_set() was already preceded by a call to get_scale() or setting the [hv]scale fields, so they will be always be up-to-date w.r.t. width and height. Removing the call to get_scale() from cx231xx_resolution_set() allowed making get_scale() a static function, which is a good thing for something with such a short name. There is already another function with the same name in the em28xx driver, but that one is static. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-05-30cx231xx: Use v4l bounding/alignment functionTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l function has a better algorithm for aligning image size. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> CC: Srinivasa Deevi <srinivasa.deevi@conexant.com>
2009-04-02v4l2-subdev: change s_routing prototypeHans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl> It is no longer needed to use a struct pointer as argument, since v4l2_subdev doesn't require that ioctl-like approach anymore. Instead just pass the input, output and config (new!) arguments directly. Priority: normal Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
2009-04-01v4l2-subdev: move s_std from tuner to core.Hans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl> s_std didn't belong in the tuner ops. Stricly speaking it should be part of the video ops, but it is used by audio and tuner devices as well, so it is more efficient to make it part of the core ops. Priority: normal Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
2009-04-01v4l2-subdev: move s_standby from core to tuner.Hans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl> s_standby is only used to put the tuner in powersaving mode, so move it from core to tuner. Priority: normal Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
2009-03-22cx231xx: use usb_make_path() for bus_infoMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> VIDIOC_QUERYCAP should return the proper bus info. In the case of USB, this should be generated by usb_make_path(), being something like: usb-0000:00:1d.7-2 Priority: normal CC: Srinivasa Deevi <srinivasa.deevi@conexant.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-22cx231xx: dmesg cleanupMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Remove some printk's that were needed only during development phase. Also, cleans the printed messages to produce a nicer result. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-21cx231xx: fix an inverted logic at vidioc_streamoffMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Priority: normal CC: Srinivasa Deevi <srinivasa.deevi@conexant.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-21cx231xx: Use generic names for each device blockMauro Carvalho Chehab
From: Sri Deevi <Srinivasa.Deevi@conexant.com> Priority: normal Signed-off-by: Srinivasa Deevi <srinivasa.deevi@conexant.com> Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-20cx231xx: convert the calls to subdev formatMauro Carvalho Chehab
From: Sri Deevi <Srinivasa.Deevi@conexant.com> This patch converts cx231xx to the new v4l2 dev/subdev, doing: - Conversion of i2c calls to subdev calls; - all subdev calls to call_all(); - Corrected the header file order in cx231xx.h; - Added tuner frequency setting. Priority: normal Signed-off-by: Srinivasa Deevi <srinivasa.deevi@conexant.com> Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-13Fix compilation with -git treeMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Due to the out-of-tree and in-kernel -git tree, a few changes are required, in order to properly compile cx231xx with -git. kernel-sync: CC: Sri Deevi <Srinivasa.Deevi@conexant.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-10Some additional CodingStyle and minor fixesMauro Carvalho Chehab
From: Srinivasa Deevi <srinivasa.deevi@conexant.com <mailto:srinivasa.deevi@conexant.com>> changed the pcb-config.c/h to pcb-cfg.c/h for short names. Signed-off-by: Srinivasa Deevi <srinivasa.deevi@conexant.com<mailto:srinivasa.deevi@conexant.com>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-04cx231xx: Fix CodingStyleMauro Carvalho Chehab
From: Sri Deevi <Srinivasa.Deevi@conexant.com> Fixes several CodingStyle issues on the driver. Signed-off-by: Srinivasa Deevi <srinivasa.deevi@conexant.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-03cx231xx: First series of manual CodingStyle fixesMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> This patch cleans up CodingStyle on the following source files: There are still much more to be fixed on later patches Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-03cx231xx: CodingStyle automatic fixes with LindentMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-03Add cx231xx USB driverMauro Carvalho Chehab
From: Sri Deevi <Srinivasa.Deevi@conexant.com> Signed-off-by: Srinivasa Deevi <srinivasa.deevi@conexant.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>