summaryrefslogtreecommitdiff
path: root/linux/drivers/media/video
AgeCommit message (Collapse)Author
2009-03-28zr364xx: Remove code for things already done by video_ioctl2Trent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The ->vidioc_(s|g|try|enum)_fmt_vid_cap() methods are only called on VIDEO_CAPTURE buffers. Thus, there is no need to check or set the buffer's 'type' field since it must already be set to VIDEO_CAPTURE. Checking the buffer type can be removed from zr364xx_vidioc_(s|g|try|enum)_fmt_vid_cap(). The v4l2 core code in v4l2_ioctl will zero out the structure the driver is supposed to fill in for read-only ioctls. For read/write ioctls, all the fields which aren't supplied from userspace will be zeroed out. Zeroing code can be removed from zr364xx_vidioc_querycap(), zr364xx_vidioc_enum_input(), zr364xx_vidioc_enum_fmt_vid_cap(), and zr364xx_vidioc_g_fmt_vid_cap(). Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> CC: Antoine Jacquet <royale@zerezo.com>
2009-03-28usbvision: Remove buffer type checks from enum_fmt_vid_cap, XXXbufTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used with vidioc_(q|dq|query)buf() and vidioc_reqbufs(). Since this driver only defines ->vidioc_try_fmt_vid_cap() the checks can be removed from vidioc_reqbufs(), vidioc_qbuf(), and vidioc_dqbuf(). The ->vidioc_(s|g|try|enum)_fmt_vid_cap() methods are only called on VIDEO_CAPTURE buffers. Thus, there is no need to check or set the buffer's 'type' field since it must already be set to VIDEO_CAPTURE. So setting the buffer type in vidioc_enum_fmt_vid_cap() can be removed. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28meye: Remove buffer type checks from XXX_fmt_vid_cap, XXXbufTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The ->vidioc_(s|g|try|enum)_fmt_vid_cap() methods are only called on VIDEO_CAPTURE buffers. Thus, there is no need to check or set the buffer's 'type' field since it must already be set to VIDEO_CAPTURE. The v4l2-ioctl core only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used with vidioc_(q|dq|query)bufs() and vidioc_reqbufs(). Since this driver only defines ->vidioc_try_fmt_vid_cap() the checks can be removed from vidioc_reqbufs(), vidioc_querybuf(), vidioc_qbuf(), and vidioc_dqbuf(). Also, the buffer index is unsigned so it's not necessary to check if it is less than zero. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28cx88-blackbird: Stop setting buffer type in XXX_fmt_vid_capTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The ->vidioc_(s|g|try|enum)_fmt_vid_cap() methods are only called on VIDEO_CAPTURE buffers. Thus, there is no need to check or set the 'type' field since it must already be set to VIDEO_CAPTURE. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28cx23885-417: Don't need to zero ioctl parameter fieldsTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2 core code in v4l2_ioctl will zero out the structure the driver is supposed to fill in for read-only ioctls. For read/write ioctls, all the fields which aren't supplied from userspace will be zeroed out. Zeroing code is removed from enum_input, g_tuner, g_frequency, querycap, enum_fmt_vid_cap, g_fmt_vid_cap, and try_fmt_vid_cap. The ->vidioc_(s|g|try|enum)_fmt_vid_cap() methods are only called on VIDEO_CAPTURE buffers. Thus, there is no need to check or set the buffer's 'type' field since it must already be set to VIDEO_CAPTURE. There also appeared to be a copy and paste error in vidioc_try_fmt_vid_cap() that would set f->fmt.pix.sizeimage to zero. Note that the s_fmt_vid_cap method doesn't appear to actually do anything. Whatever parameters were requested are just silently ignored. Was this intentional? Who knows, as the commit log entry for the driver just says, "Add generic cx23417 hardware encoder support." There are no docs. A comment like "this driver totally ignores the v4l2 spec w.r.t. VIDIOC_S_FMT because ..." would have gone a long way. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> CC: Steven Toth <stoth@hauppauge.com>
2009-03-28cafe_ccic: Remove buffer type check from XXXbufTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used with vidioc_(q|dq|query)bufs() and vidioc_reqbufs(). This driver only defines ->vidioc_try_fmt_vid_cap() so only VIDEO_CAPTURE buffers are allowed to be used with cafe_vidioc_reqbufs(), cafe_vidioc_querybuf(), cafe_vidioc_qbuf(), and cafe_vidioc_dqbuf(). The ->vidioc_(s|g|try|enum)_fmt_vid_cap() methods are only called on VIDEO_CAPTURE buffers. Thus, there is no need to check or set the buffer's 'type' field since it must already be set to VIDEO_CAPTURE. So the check in cafe_vidioc_enum_fmt_vid_cap() can be removed. The 'index' field of v4l2_buffer is unsigned so the checks for it being less than zero can be removed too. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28vino: Remove code for things already done by video_ioctl2Trent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used in vidioc_(g|s)_parm, vidioc_(q|dq|query)buf, and vidioc_reqbufs. Remove buffer type checking from vino_g_parm(), vino_s_parm(), vino_reqbufs(), vino_querybuf(), vino_qbuf(), and vino_dqbuf(). This reduced the indent level of the code so a few lines can be wrapped better. Also fixed the C++ type comments. The v4l2-ioctl core also provides structs that have been pre-zeroed for all fields that driver is supposed to fill in, so remove zeroing code from vino_enum_fmt_vid_cap(). Also, the format index is unsigned so it's not necessary to check if it's less than zero. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28stkwebcam: Remove buffer type check from g_parm and q/dq/reqbufsTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used with vidioc_(q|dq|query)bufs(), vidioc_reqbufs() and now vidioc_(s|g)_parm. This driver only defines ->vidioc_try_fmt_vid_cap() so only VIDEO_CAPTURE buffers are allowed to be used with vidioc_g_parm(), vidioc_qbuf(), vidioc_dqbuf(), and vidioc_reqbufs(). Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> CC: Jaime Velasco Juan <jsagarribay@gmail.com>
2009-03-28omap24xxcam: Remove buffer type check from vidioc_s/g_parmTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core now only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used in vidioc_(g|s)_parm. This driver only defines ->vidioc_try_fmt_vid_cap() so only VIDEO_CAPTURE buffers are allowed to be used with vidioc_s_parm() and vidioc_g_parm(). Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> CC: Sakari Ailus <sakari.ailus@nokia.com>
2009-03-28gspca: Stop setting buffer type, and avoid memset in querycapTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core checks the buffer type now by only allowing buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined. This driver only defines ->vidioc_try_fmt_vid_cap() so only VIDEO_CAPTURE buffers are allowed to be used with vidioc_g_parm. Also, ->vidioc_enum_fmt_vid_cap() is only called for VIDEO_CAPTURE buffers. There is no need to set the buffer type since it must already be the correct value. The struct which ->vidioc_querycap() is supposed to fill in is already zeroed so it's not necessary to call memset on it. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> CC: Jean-Francois Moine <moinejf@free.fr>
2009-03-28bttv: Remove buffer type check from vidioc_g_parmTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> The v4l2-ioctl core only allows buffer types for which the corresponding ->vidioc_try_fmt_xxx() methods are defined to be used with vidioc_(q|dq|query)bufs(), vidioc_reqbufs() and now vidioc_(s|g)_parm. The driver was only allowing VIDEO_CAPTURE buffers for g_parm, but since the driver defines ->vidioc_try_fmt_vid_overlay() and ->vidioc_try_fmt_vbi_cap() it will now allow VIDEO_OVERLAY and VBI_CAPTURE buffers as well. This should be fine as the driver only fills in the frame rate field, which is just as valid for video overlay and vbi capture as it is for video capture. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28v4l2-ioctl: Check format for S_PARM and G_PARMTrent Piepho
From: Trent Piepho <xyzzy@speakeasy.org> Return EINVAL if VIDIOC_S/G_PARM is called for a buffer type that the driver doesn't define a ->vidioc_try_fmt_XXX() method for. Several other ioctls, like QUERYBUF, QBUF, and DQBUF, etc. do this too. It saves each driver from having to check if the buffer type is one that it supports. Priority: normal Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
2009-03-28cx231xx: Fix Kconfig help itemsMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-28hdpvr: empty internal device buffer after stopping streamingJanne Grunau
From: Janne Grunau <j@jannau.net> Makes the next capturing starting faster and more reliable. Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-28hdpvr: convert printing macros to v4l2_* with struct v4l2_deviceJanne Grunau
From: Janne Grunau <j@jannau.net> it gives us a nice and unique prefix per device Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-28hdpvr: add struct v4l2_deviceJanne Grunau
From: Janne Grunau <j@jannau.net> Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-26[PATCH] cx88: Missing failure checksMauro Carvalho Chehab
From: Alan Cox <alan@lxorguk.ukuu.org.uk> The ioremap one was reported in October 2007 (Bug 9146), the kmalloc one was blindingly obvious while looking at the ioremap one The bug suggests some other configuration for lots of I/O memory (32MB per device is ioremapped) but I'll leave that to the real maintainers Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-26allow v4l2 drivers to provide a get_unmapped_area handlerMauro Carvalho Chehab
From: Daniel Glöckner <dg@emlix.com> Shared memory mappings on nommu machines require a get_unmapped_area file operation that suggests an address for the mapping. This patch adds a way for v4l2 drivers to provide this callback. Signed-off-by: Daniel Glöckner <dg@emlix.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-27Fix printk format warning:Mauro Carvalho Chehab
From: Randy Dunlap <randy.dunlap@oracle.com> drivers/media/video/zoran/zoran_driver.c:345: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'phys_addr_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-24changed ioctls to unlockedMauro Carvalho Chehab
From: Stoyan Gaydarov <stoyboyker@gmail.com> Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-26merge: http://hg.jannau.net/hdpvr-merge/Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-27hdpvr: locking fixesJanne Grunau
From: Janne Grunau <j@jannau.net> unlock io_mutex in hdpvr_stop_streaming hdpvr_disconnect to allow the streaming worker to stop before we flush the workqueue. do not return to user space with mutex held in vidioc_encoder_cmd with an unknown encoder command. Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-26hdpvr: return immediately from hdpvr_poll if data is availableJanne Grunau
From: Janne Grunau <j@jannau.net> simplifies check for available data with hdpvr_get_next_buffer Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-26hdpvr: set usb interface dev as parent in struct video_deviceJanne Grunau
From: Janne Grunau <j@jannau.net> Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-27hdpvr: use debugging macro for buffer statusJanne Grunau
From: Janne Grunau <j@jannau.net> Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-26avoid warnings for request_ihex_firmware on dabusb and vicamMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> drivers/media/video/usbvideo/vicam.c: In function ‘vicam_open’: drivers/media/video/usbvideo/vicam.c:194: warning: ‘fw’ may be used uninitialized in this function drivers/media/video/dabusb.c: In function ‘dabusb_probe’: drivers/media/video/dabusb.c:337: warning: ‘fw’ may be used uninitialized in this function Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-26pvrusb2: add a missing source at MakefileMauro Carvalho Chehab
From: Kyle McMartin <kyle@redhat.com> As pointed by Steve Dickson, pvrusb2 Makefile was not compiling pvrusb2-cx53l32a driver. Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-26gspca - zc3xx: The webcam DLink DSB - C320 has the sensor pas106.Jean-Francois Moine
From: Douglas Schilling Landgraf <dougsland@redhat.com> Reported-by: Bruna Griebeler <bruna@griebeler.com> Priority: normal Tested-by: Bruna Griebeler <bruna@griebeler.com> Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-26gspca - sonixj: Prefer sonixj instead of sn9c102 for 0471:0327.Jean-Francois Moine
From: Hans de Goede <hdegoede@redhat.com> Prefer the gspca sonixj driver for the Philips SPC600NC webcam instead of the sn9c102 driver. As we've got userreports that it works with the gspca driver, whereas it fails with the sn9c102 driver, see: https://bugzilla.redhat.com/show_bug.cgi?id=477111 Priority: normal Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-26gspca - finepix: Use a workqueue for streaming.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Tested-by: Frank Zago <frank@zago.net> Acked-by: Frank Zago <frank@zago.net> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-26gspca - sq905: Optimize the resolution setting.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-26gspca - sq905: Update the frame pointer after adding the last packet.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-25hg merge: http://linuxtv.org/hg/~jfrancois/v4l-dvb/Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-25gspca - sq905c: New subdriver.Jean-Francois Moine
From: Theodore Kilgore <kilgota@auburn.edu> The code in the new sq905c.c is based upon the structure of the code in gspca/sq905.c, and upon the code in libgphoto2/camlibs/digigr8, which supports the same set of cameras in stillcam mode. I am a co-author of gspca/sq905.c and I am the sole author of libgphoto2/camlibs/digigr8, which is licensed under the LGPL. I hereby give myself permission to use my own code from libgphoto2 in gspca/sq905c.c. Priority: normal Signed-off-by: Theodore Kilgore <kilgota@auburn.edu> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-25gspca - vc032x: Use YVYU format for sensor mi1320_soc.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-25gspca - vc032x: Simplify the i2c write function.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-24pvrusb2: Use v4l2_device_disconnect()Mike Isely
From: Mike Isely <isely@pobox.com> Priority: normal Signed-off-by: Mike Isely <isely@pobox.com>
2009-03-24merge: v4l-dvbJean-Francois Moine
2009-03-23merge: http://hg.jannau.net/hdpvr-merge/Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-23merge: http://www.linuxtv.org/hg/~hverkuil/v4l-dvbMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-23merge: http://linuxtv.org/hg/~jfrancois/v4l-dvb/Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-03-23hdpvr: Fix build with Config_I2C not setJanne Grunau
From: Janne Grunau <j@jannau.net> Priority: normal Signed-off-by: Janne Grunau <j@jannau.net>
2009-03-23ov7670: add missing delay.h include.Hans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl> Priority: normal Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
2009-03-23gspca - vc032x: New sensor mi1320_soc and webcam 15b8:6001 added.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
2009-03-23merge: v4l-dvbJean-Francois Moine
2009-03-22au0828: fix oops on ARM platform when allocating transfer buffersDevin Heitmueller
From: Devin Heitmueller <dheitmueller@linuxtv.org> Add missing URB_NO_TRANSFER_DMA_MAP flag, since the use of consistent memory is not permitted for DMA on the ARM platform. Thanks to Paul Thomas <pthomas8589@gmail.com> for providing sample ARM hardware that was experiencing the oops (tested on the at91rm9200 based LinuxStamp). Thanks to David Brownell <david-b@pacbell.net> for providing insight into the ARM memory architecture. Priority: normal Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
2009-03-22em28xx: fix oops on ARM platform when allocating transfer buffersDevin Heitmueller
From: Devin Heitmueller <dheitmueller@linuxtv.org> Add missing URB_NO_TRANSFER_DMA_MAP flag, since the use of consistent memory is not permitted for DMA on the ARM platform. Thanks to Paul Thomas <pthomas8589@gmail.com> for providing sample ARM hardware that was experiencing the oops (tested on the at91rm9200 based LinuxStamp). Thanks to David Brownell <david-b@pacbell.net> for providing insight into the ARM memory architecture. Priority: high Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
2009-03-22usbvision: fix oops on ARM platform when allocating transfer buffersDevin Heitmueller
From: Devin Heitmueller <dheitmueller@linuxtv.org> Add missing URB_NO_TRANSFER_DMA_MAP flag, since the use of consistent memory is not permitted for DMA on the ARM platform. Thanks to Paul Thomas <pthomas8589@gmail.com> for providing sample ARM hardware that was experiencing the oops (tested on the at91rm9200 based LinuxStamp). Thanks to David Brownell <david-b@pacbell.net> for providing insight into the ARM memory architecture. Priority: normal Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
2009-03-22em28xx: add remote control definition for HVR-900 (both versions)Devin Heitmueller
From: Devin Heitmueller <dheitmueller@linuxtv.org> The HVR-900 did not have a remote control defined, so it would not work. Add the line for both versions of the product. Thanks to Jens-Michael Hoffmann (#linuxtv user "jmho") for pointing out the issue and testing the patch. Priority: normal Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
2009-03-22gspca - vc032x: Change the probe sequence.Jean-Francois Moine
From: Jean-Francois Moine <moinejf@free.fr> Priority: normal Signed-off-by: Jean-Francois Moine <moinejf@free.fr>