summaryrefslogtreecommitdiff
path: root/linux/drivers/media
AgeCommit message (Collapse)Author
2006-06-23Fix use-after-free bug in cpia2 driverMauro Carvalho Chehab
From: Jesper Juhl <jesper.juhl@gmail.com> The coverity checker detected a use-after-free error in drivers/media/video/cpia2/cpia2_v4l.c::cpia2_close() (coverity error #1281). What happens is that we lock cam->busy_lock, then proceed to free resources, and in the case of (--cam->open_count == 0) we finish off by doing a kfree(cam) and then at the end of the function we do a mutex_unlock(&cam->busy_lock) which will explode since it'll dereference the free'd `cam' : ... mutex_lock(&cam->busy_lock); ... if (--cam->open_count == 0) { ... if (!cam->present) { video_unregister_device(dev); kfree(cam); } } mutex_unlock(&cam->busy_lock); <--- PROBLEM, cam no longer around. ... Since this only happens in the case of open_count going down to zero I don't see a problem with just releasing the mutex after unregistering the device and just before the kfree(). In this case there is nothing around that we can race against; we are in the release method, open_count is zero, (!cam->present) and the device has just been unregistered, so letting go of the mutex at this point looks safe to me. Patch below to implement that solution. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Acked-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-23merge: http://linuxtv.org/hg/~mkrufky/cx88Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-23fix up funky logic in dvbMauro Carvalho Chehab
From: Dave Jones <davej@redhat.com> Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-23fix userbits debug printsMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@infradead.org> Previously, it were showing the pointer value, instead of the setted bits. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-23drivers/media/video/pwc/: make code staticMauro Carvalho Chehab
From: Adrian Bunk <bunk@stusta.de> This patch makes the following needlessly global code static: - pwc-ctrl.c: pwc_get_leds() - pwc_preferred_compression Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-23drivers/media/video/vivi.c: make 2 functions staticMauro Carvalho Chehab
From: Adrian Bunk <bunk@stusta.de> Make two needlessly global functions static. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-22cx88: clear EN_I2SIN_ENABLE bit for ASUS PVR-416 to enable audioMichael Krufky
From: Michael Krufky <mkrufky@linuxtv.org> clear EN_I2SIN_ENABLE bit for ASUS PVR-416 to enable audio streaming in both raw video and blackbird mpeg encoder modes. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
2006-06-22cx88-blackbird: always set encoder height based on tvnorm->idMichael Krufky
From: Michael Krufky <mkrufky@linuxtv.org> Removed the switch..case block in blackbird_probe for setting encoder height based on video standard. All blackbird devices can rely on tvnorm->id to retrieve this information from the cx2388x video decoder - tuner_formats should not be used to determine the encoding video standard. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
2006-06-22Add support for the DNTV Live! mini DVB-T card.Manu Abraham
From: Cameron Hutchinson <camh@xdna.net> Signed-off-by: Cameron Hutchinson <camh@xdna.net>
2006-06-22conditionally enable 5 byte diseqc commandsManu Abraham
From: Yeasah Pell <yeasah@schwide.net> Signed-off-by: Yeasah Pell <yeasah@schwide.net> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-22Static variables mustn't be EXPORT_SYMBOL 'edManu Abraham
From: Adrian Bunk <bunk@stusta.de> Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-22The Coverity checker spotted that there was a memory leak if the second or ↵Manu Abraham
third kmalloc() failed. Besides this, i have also consolidated the three error handlings into one and removed the unneeded casts. From: Adrian Bunk <bunk@stusta.de> Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21CX2341X port was always set to 'memory', but 'streaming' is also possibleHans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl> ivtv uses the memory (DMA) interface with the CX2341X, while pvrusb2 and cx88-blackbird use the streaming interface. This setting is now selectable by the driver. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
2006-06-22Comment out MMI functions for nowManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Fix CA Info and Application InfoManu Abraham
From: Henrik Sjoberg <hsjo@epact.se> Signed-off-by: Henrik Sjoberg <hsjo@epact.se> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21cx88: add support for FusionHDTV 3 Gold (original revision)Michael Krufky
From: Michael Krufky <mkrufky@linuxtv.org> Add support for FusionHDTV 3 Gold (original revision), using the card definition for FusionHDTV3 Gold-Q Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
2006-06-21merge: http://linuxtv.org/hg/~rmcc/v4l-dvbMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-21Initial go at MMIManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21VLF fixes for DCTManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21replace NEWTUNE with TS188Manu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21DCTNEW and ATSC fixesManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Bug-fix: Do not overflow kernel memory when more than BT878_MAX devices are ↵Manu Abraham
present From: Sigmund Augdal Helberg <sigmund@snap.tv> Signed-off-by: Sigmund Augdal Helberg <sigmund@snap.tv> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21fix a bug in tuner detectionManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21distinguish between STV0299 and MB86A15 based NIM'sManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21dprintk macro beautificationManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Remove spurious newlines in dprintk's. Add dst(card-num) as prefix in dprintkManu Abraham
From: Sigmund Augdal Helberg <sigmund@snap.tv> Signed-off-by: Sigmund Augdal Helberg <sigmund@snap.tv> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Fix Daughterboard detectionManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21ATSC typecheck bugfixManu Abraham
From: Bryan Scott <sirbryan@gmail.com> Signed-off-by: Bryan Scott <sirbryan@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Add more Firmware and Tuner namesManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21ATSC tuner doesn't have variable length fieldManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Add Board NamesManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Fix string lengthManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Add in tuner namesManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Add DVB-S specific demod namesManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Initialize ATSC frontendManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Explicit defining of type is not necessary with MULTI_FEManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Utilize the device specific algorithm callbacksManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Use device specific algorithmsManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Implement tuning algorithm as a module parameterManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Make ASIC RESET ConditionalManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Add support for VP-3250 ATSC cardManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21Add basic ATSC support to DSTManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-21ATSC frontend supportManu Abraham
From: Manu Abraham <abraham.manu@gmail.com> Signed-off-by: Manu Abraham <manu@linuxtv.org>
2006-06-20kconfig: saa7115 depends on VIDEO_DEV, not VIDEO_V4l1Michael Krufky
From: Michael Krufky <mkrufky@linuxtv.org> ... another leftover bug from a previous merge Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
2006-06-20Kconfig: fix description for saa7115 moduleMichael Krufky
From: Michael Krufky <mkrufky@linuxtv.org> This Kconfig description is incorrect, due to a previous merge a while back. CONFIG_SAA711X builds module saa7115, which is the newer module, and is not obsoleted. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
2006-06-20merge: http://linuxtv.org/hg/~mkrufky/v4l-dvbMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-20Ovcamship position at Kconfig changedMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@infradead.org> Ovcamship is used only on some USB webcams (OV511 and W9968CF) Bettet to leave this item just after those webcams. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-20lgdt330x: fix missing line in VSB snr decoding logicMichael Krufky
From: Mac Michaels <wmichaels@earthlink.net> - fix missing line in VSB snr decoding logic for lgdt3303 Signed-off-by: Mac Michaels <wmichaels@earthlink.net> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
2006-06-20Whitespace cleanupsMauro Carvalho Chehab
From: Trent Piepho <xyzzy@speakeasy.org> Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2006-06-19saa7134 card (LifeView3000 NTSC)Mauro Carvalho Chehab
From: Zac Bowling <zac@zacbowling.com> Add detection for the LifeView3000 NTSC model (right now the PAL version is the only one in there, which is sort of annoying for me living in the US and all.. sigh...) This is one of those things that I like to classify "as a works for me so take it or leave it" :-) . Not that worried because its an $18 video capture card that didn't look it was selling to well in the US, but then again who knows. The documentation needs updating too I bet but its behind anyways usually to what is in the code. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Zac Bowling <zac@zacbowling.com> Signed-off-by: Andrew Morton <akpm@osdl.org>
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-24 17:14:35 +0000