From 0082053685c27f18e24c1d3e564bb43f51fc28f4 Mon Sep 17 00:00:00 2001 From: Douglas Schilling Landgraf Date: Sun, 5 Jul 2009 15:44:20 -0300 Subject: radio-si470x: fix lock imbalance From: Jiri Slaby There is one path with omitted unlock in si470x_fops_release. Fix that. Priority: normal Signed-off-by: Jiri Slaby CC: Tobias Lorenz Signed-off-by: Douglas Schilling Landgraf --- linux/drivers/media/radio/radio-si470x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/linux/drivers/media/radio/radio-si470x.c b/linux/drivers/media/radio/radio-si470x.c index de4673b3a..20aa447cc 100644 --- a/linux/drivers/media/radio/radio-si470x.c +++ b/linux/drivers/media/radio/radio-si470x.c @@ -1206,7 +1206,7 @@ static int si470x_fops_release(struct file *file) kfree(radio->int_in_buffer); kfree(radio->buffer); kfree(radio); - goto done; + goto unlock; } /* cancel read processes */ @@ -1216,9 +1216,8 @@ static int si470x_fops_release(struct file *file) retval = si470x_stop(radio); usb_autopm_put_interface(radio->intf); } - +unlock: mutex_unlock(&radio->disconnect_lock); - done: return retval; } -- cgit v1.2.3