From b171b4bf6091c1b3482b7ac3c14e1672f10c6950 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Fri, 27 Jun 2008 11:19:39 -0300 Subject: Improves commit message scripts From: Mauro Carvalho Chehab This patch improves message description sanity rules: - mailimport now prefers to edit using editdiff. This helps to fix trivial CodingStyle errors at receive patches; - hghead.pl will now remove blank whitespaces if no body exists; - "make commit" will now run hghead.pl. This will do some sanity checks at commit messages: *) Will warrant that "from:" metatag exists, avoiding to have patches without proper authorship id at someone's else tree; *) Will order the tags at the expected way (subject, from, body, signatures); *) Will warrant that one and just one blank line exists between each of the four parts of the commit message. Signed-off-by: Mauro Carvalho Chehab --- mailimport | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) (limited to 'mailimport') diff --git a/mailimport b/mailimport index 76364aeea..bd6d36c2e 100755 --- a/mailimport +++ b/mailimport @@ -34,7 +34,7 @@ edit_patch() mv $tmp/$newfile $next; fi echo Editing $next - $EDITOR $next + $ED $next } #################################################################### @@ -80,7 +80,7 @@ apply_patch () { if [ "`grep '^Bad:' $TMP2`" != "" ]; then echo "*** ERROR: Patch bad formed. Please fix." sleep 1 - $EDITOR $next + $ED $next cont=1 fi done @@ -214,8 +214,20 @@ if [ "$TMPDIR" == "" ]; then TMPDIR=/tmp fi -if [ "$EDITOR" == "" ]; then - EDITOR="nano -w" +if [ "`which editdiff`" != "" ]; then + ED="editdiff" +else + ED=$EDITOR +fi + +if [ "$ED" == "" ]; then + if [ "`which nano`" != "" ]; then + ED="nano -w" + elif [ "`which pico`" != "" ]; then + ED="pico -w" + else + ED="vi" + fi fi if [ "$CHECKPATCH" == "" ]; then -- cgit v1.2.3