From fb85cdf9f18700f9dbe3f02c59e18662bc04cea9 Mon Sep 17 00:00:00 2001 From: Dieter Hametner Date: Fri, 25 Jan 2008 22:26:57 +0100 Subject: Removed debug messages in the recordings_items constructors and destructors introduced to find the memory leak problem when the recordings list was recreated. Updated changelog with the latest changes. --- doc/ChangeLog | 28 ++++++++++++++++++++++------ recman.cpp | 8 ++++---- 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/doc/ChangeLog b/doc/ChangeLog index ba3e3c6..20f25b5 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,15 +1,31 @@ +2008-01-25 Dieter Hametner + + * recman.cpp: Fixed memory leak, which resulted through the use of + circular references by using tr1::shared_ptr, where a + tr1::weak_ptr would have been needed. + + * pages/recordings.ecpp: Added button to delete that single + recording. This feature is somehow limited in usability and + should be used only for occasional deletion of recordings, + because the page reloads when a recording is + deleted. Unfortunately there is currently no way to remember the + position to where the user navigated before he hit the delete + button. In order to delete an other recording in the same + subdirectory he will need to navigate there again after the page + reloaded. + 2008-01-18 Dieter Hametner * buildutil/version-util*: Added a shell and an awk script to calculate a version suffix string out of CVS current working dir status. This was a request bei jo01 and helps distinguish if newer versions are awailable. It should not break builds if - something goes wrong in the script. At least it was my intention. - The script also support git repositories. But it has not been - tested if it determines the correct git commit id based on - current workdir contents. - The caluculated version suffix is appended to the LIVE version - string visible in the about box (?-Menu entry). + something goes wrong in the script. At least it was my + intention. The script also supports git repositories. But it + has not been tested if it determines the correct git commit id + based on current workdir contents. The caluculated version + suffix is appended to the LIVE version string visible in the + about box (?-Menu entry). 2008-01-15 Christian Wieninger * whats_on.ecpp: added listing 'Favorites', that lists all search diff --git a/recman.cpp b/recman.cpp index c7010e7..26d78d9 100644 --- a/recman.cpp +++ b/recman.cpp @@ -207,12 +207,12 @@ namespace vdrlive { RecordingsItem(name, parent), m_level(level) { - dsyslog("REC: C: dir %s -> %s", name.c_str(), parent ? parent->Name().c_str() : "ROOT"); + // dsyslog("REC: C: dir %s -> %s", name.c_str(), parent ? parent->Name().c_str() : "ROOT"); } RecordingsItemDir::~RecordingsItemDir() { - dsyslog("REC: D: dir %s", Name().c_str()); + // dsyslog("REC: D: dir %s", Name().c_str()); } @@ -224,12 +224,12 @@ namespace vdrlive { m_recording(recording), m_id(id) { - dsyslog("REC: C: rec %s -> %s", name.c_str(), parent->Name().c_str()); + // dsyslog("REC: C: rec %s -> %s", name.c_str(), parent->Name().c_str()); } RecordingsItemRec::~RecordingsItemRec() { - dsyslog("REC: D: rec %s", Name().c_str()); + // dsyslog("REC: D: rec %s", Name().c_str()); } time_t RecordingsItemRec::StartTime() const -- cgit v1.2.3