From 914fc339749a5d625bc0aa6367cb1c950df7702b Mon Sep 17 00:00:00 2001 From: Jasmin Jessich Date: Sun, 18 Jun 2017 02:13:40 +0200 Subject: Protect stored timers in SortedTimers list - SortedTimers::GetByTimerId will now return "const cTimer *" to be sure the timer is never modified within live. Modifying or more worse deleting such a timer can lead to a segfault. This is no longer the case, but using const may protect future mistakes. --- pages/edit_timer.ecpp | 2 +- pages/timers.ecpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'pages') diff --git a/pages/edit_timer.ecpp b/pages/edit_timer.ecpp index 24bd022..a466ef6 100644 --- a/pages/edit_timer.ecpp +++ b/pages/edit_timer.ecpp @@ -48,7 +48,7 @@ string edit_timerreferer; TimerConflictNotifier timerNotifier; <%request scope="page"> -cTimer* timer; +const cTimer* timer; <%include>page_init.eh <%cpp> diff --git a/pages/timers.ecpp b/pages/timers.ecpp index 91986dd..7b7bdc3 100644 --- a/pages/timers.ecpp +++ b/pages/timers.ecpp @@ -23,7 +23,7 @@ static const size_t maximumDescriptionLength = 300; bool logged_in(false); <%request scope="page"> - cTimer* timer; + const cTimer* timer; TimerConflictNotifier timerNotifier; <%include>page_init.eh -- cgit v1.2.3