From 54ce728fa5a81cd5c5415ecf0f4e32a0eeb265af Mon Sep 17 00:00:00 2001
From: kamel5 <vdr.kamel5 (at) gmx (dot) net>
Date: Sat, 9 Nov 2019 14:01:19 +0100
Subject: Refactor cRecMenuSearchTimers

---
 recmenus.c | 40 +++++++++++++++-------------------------
 1 file changed, 15 insertions(+), 25 deletions(-)

(limited to 'recmenus.c')

diff --git a/recmenus.c b/recmenus.c
index e451be0..0ee0427 100644
--- a/recmenus.c
+++ b/recmenus.c
@@ -665,37 +665,27 @@ TVGuideEPGSearchTemplate cRecMenuSearchTimerTemplates::GetTemplate(void) {
 }
 
 // --- cRecMenuSearchTimers  ---------------------------------------------------------
-cRecMenuSearchTimers::cRecMenuSearchTimers(std::vector<cTVGuideSearchTimer> searchTimers) {
+cRecMenuSearchTimers::cRecMenuSearchTimers(std::vector<cTVGuideSearchTimer> searchTimers) { // OK
+    SetWidthPercent(70);
+
     this->searchTimers = searchTimers;
     numSearchTimers = searchTimers.size();
-    SetWidthPercent(70);
-    cString headline;
-    if (numSearchTimers > 0) {
-        headline = tr("EPGSearch Search Timers");
-    } else {
-        headline = tr("No Search Timers Configured");
-    } 
-    cRecMenuItemInfo *infoItem = new cRecMenuItemInfo(*headline, true);
-    infoItem->CalculateHeight(width - 2 * border);
-    SetHeader(infoItem);
-    cRecMenuItem *button = new cRecMenuItemButton(tr("Close"), rmsClose, (!numSearchTimers)?true:false);
-    SetFooter(button);
-    if (numSearchTimers > 0)
-        SetMenuItems();    
-    CalculateHeight();
-    CreatePixmap();
-    Arrange();
-}
 
-cRecMenuSearchTimers::~cRecMenuSearchTimers(void) {
+    const cString line1 = (numSearchTimers > 0) ? tr("EPGSearch Search Timers") : tr("No Search Timers Configured");
 
-}
+    AddHeader(new cRecMenuItemInfo(*line1, 1, "", "", "", width - 2 * border, true));
+    AddFooter(new cRecMenuItemButton(tr("Close"), rmsClose, (!numSearchTimers) ? true : false));
 
-void cRecMenuSearchTimers::SetMenuItems(void) {
-    for (int i = 0; i < numSearchTimers; i++) {
-        if (!AddMenuItemInitial(new cRecMenuItemSearchTimer(searchTimers[i], rmsSearchTimerTest, rmsSearchTimerEdit, rmsSearchTimerDeleteConfirm, (i==0)?true:false)))
-            break;
+    if (numSearchTimers > 0) {
+        for (int i = 0; i < numSearchTimers; i++) {
+            if (!AddMenuItemInitial(new cRecMenuItemSearchTimer(searchTimers[i], rmsSearchTimerTest, rmsSearchTimerEdit, rmsSearchTimerDeleteConfirm, (i == 0) ? true : false)))
+                break;
+        }
     }
+
+    CalculateHeight();
+    CreatePixmap();
+    Arrange();
 }
 
 cTVGuideSearchTimer cRecMenuSearchTimers::GetSearchTimer(void) {
-- 
cgit v1.2.3