From 2a0222226a07a8ac8b3ea5c24591421b43bd2ef0 Mon Sep 17 00:00:00 2001
From: Klaus Schmidinger <vdr@tvdr.de>
Date: Mon, 31 Jan 2022 21:21:42 +0100
Subject: Clarified some potentially mistakable code in
 cSectionHandler::SetStatus()

---
 CONTRIBUTORS | 1 +
 HISTORY      | 4 +++-
 sections.c   | 5 +++--
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index eda44d39..7382521e 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -3617,6 +3617,7 @@ Onur Sent
  for fixing handling shared CA pids
  for fixing handling the S2SatelliteDeliverySystemDescriptor for transponders broadcasting
  in "backwards compatibility mode" according to ETSI EN 300 468
+ for pointing out some potentially mistakable code in cSectionHandler::SetStatus()
 
 Helmut Binder <cco@aon.at>
  for improving calculating signal strength and quality
diff --git a/HISTORY b/HISTORY
index 99158f26..b2f3e24c 100644
--- a/HISTORY
+++ b/HISTORY
@@ -9766,7 +9766,7 @@ Video Disk Recorder Revision History
   (reported by Timo Weingärtner).
 - Official release.
 
-2022-01-24:
+2022-01-31:
 
 - Replaced strncpy() with memcpy() in strreplace() to avoid a compiler warning
   (reported by Marco Mäkelä).
@@ -9776,3 +9776,5 @@ Video Disk Recorder Revision History
 - Fixed handling zero bytes in cH264Parser (thanks to Christoph Haubrich).
 - Fixed handling error conditions in the index file (reported by Markus Ehrnsperger).
 - Fixed a possible deadlock in cDevice::DetachAllReceivers() (thanks to Helmut Binder).
+- Clarified some potentially mistakable code in cSectionHandler::SetStatus() (pointed
+  out by Onur Sentürk).
diff --git a/sections.c b/sections.c
index 88935c7b..51a2823c 100644
--- a/sections.c
+++ b/sections.c
@@ -4,7 +4,7 @@
  * See the main source file 'vdr.c' for copyright information and
  * how to reach the author.
  *
- * $Id: sections.c 5.2 2021/06/20 10:27:19 kls Exp $
+ * $Id: sections.c 5.3 2022/01/31 21:21:42 kls Exp $
  */
 
 #include "sections.h"
@@ -155,7 +155,8 @@ void cSectionHandler::SetStatus(bool On)
             if (On)
                fi->SetStatus(true);
             }
-        if (flush = On)
+        flush = On;
+        if (flush)
            flushTimer.Set();
         on = On;
         waitForLock = false;
-- 
cgit v1.2.3