From d7c8025fba61355f6b7f8e306c930da11525cb63 Mon Sep 17 00:00:00 2001
From: Klaus Schmidinger <vdr@tvdr.de>
Date: Sun, 23 Apr 2006 09:04:32 +0200
Subject: Added an error message about plugins that don't honor APIVERSION in
 their Makefile

---
 CONTRIBUTORS | 2 ++
 HISTORY      | 2 ++
 Makefile     | 9 ++++++++-
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index b4a93e5d..46efc30a 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -1410,6 +1410,8 @@ Udo Richter <udo_richter@gmx.de>
  case a replay is active
  for reporting a problem with plugins that report errors when VDR is run with the
  --help or --version option
+ for suggesting to add a warning about plugins that don't honor APIVERSION in their
+ Makefile
 
 Sven Kreiensen <svenk@kammer.uni-hannover.de>
  for his help in keeping 'channels.conf.terr' up to date
diff --git a/HISTORY b/HISTORY
index 1189bdcd..dac02f47 100644
--- a/HISTORY
+++ b/HISTORY
@@ -4641,3 +4641,5 @@ Video Disk Recorder Revision History
   current APIVERSION (suggested by Thomas Günther).
 - Fixed handling empty titles in cEvent::FixEpgBugs() (reported by Rolf Ahrenberg).
 - Fixed some missing '-' in the German OSD texts (thanks to Walter Koch).
+- Added an error message about plugins that don't honor APIVERSION in their Makefile
+  (based on a suggestion by Udo Richter).
diff --git a/Makefile b/Makefile
index 38af4857..f671fb47 100644
--- a/Makefile
+++ b/Makefile
@@ -4,7 +4,7 @@
 # See the main source file 'vdr.c' for copyright information and
 # how to reach the author.
 #
-# $Id: Makefile 1.88 2006/04/22 09:58:44 kls Exp $
+# $Id: Makefile 1.89 2006/04/23 09:01:17 kls Exp $
 
 .DELETE_ON_ERROR:
 
@@ -176,10 +176,17 @@ include-dir:
 
 plugins: include-dir
 	@failed="";\
+	@noapiv="";\
 	for i in `ls $(PLUGINDIR)/src | grep -v '[^a-z0-9]'`; do\
 	    echo "Plugin $$i:";\
+	    if ! grep -q "\$$(LIBDIR)/.*\$$(APIVERSION)" "$(PLUGINDIR)/src/$$i/Makefile" ; then\
+	       echo "ERROR: plugin $$i doesn't honor APIVERSION - not compiled!";\
+	       noapiv="$$noapiv $$i";\
+	       continue;\
+	       fi;\
 	    $(MAKE) -C "$(PLUGINDIR)/src/$$i" all || failed="$$failed $$i";\
 	    done;\
+	if [ -n "$$noapiv" ] ; then echo; echo "*** plugins without APIVERSION:$$noapiv"; echo; fi;\
 	if [ -n "$$failed" ] ; then echo; echo "*** failed plugins:$$failed"; echo; fi
 
 clean-plugins:
-- 
cgit v1.2.3