xine-lib/src/post/goom, branch 1.1.16

Memory access fixes:

2008-11-20T20:01:27+00:00

 - goom initialization
 - matroska playing recent files with AAC
 - replace free() by ffmpeg's av_free() in ff decoders

Avoid definition of MAX that clashes with MAX() macro.

2008-07-08T13:50:55+00:00

--HG--
extra : transplant_source : %EFv%DC%FD%DA%23%BB%B8i3%07%A9e%C0%06o%9C%8A%B6_

Use proper string functions in place of sn?printf.

2008-05-07T16:06:56+00:00

Instead of calling sprintf or snprintf with a "%s" format string, use
the proper strcpy, strncpy, strdup or strndup function.

xine_xmalloc() deprecation: replace its use with static and non-zero size.

2008-05-07T14:59:00+00:00

The xine_xmalloc() function is going to be deprecated, as its
behaviour is rarely needed as such, and it's thus misused.

With this, almost all uses of xine_xmalloc() with static size (for
instance the value returned by sizeof()) or with a size that is
guaranteed not to be zero (like strlen()+1) are replaced with calls to
either calloc(1, ...) or malloc().

malloc() is used whenever the allocated memory is going to be
immediately overwritten, while calloc() is used in every other case,
as it sets the whole memory area to zero.

--HG--
extra : transplant_source : %8F%98%EC%02%1E%83%F0s%06X%83C%205Y%80%B12%CC%E1

Consistently use "colour", "colour key", "colour space" in output.

2007-12-24T18:58:26+00:00

Some instances of "key colour" remain; ffmpeg is unmodified.

This change has caused two strings with two translations to collide (the
strings have become identical since some instances already used "colour").
I have therefore arbitrarily dropped the first of the differing translations,
the one for the string at src/video_out/video_out_directfb.c:1365.

Delete most of the CVS $Id$/$Log$ lines.

2007-11-10T22:06:10+00:00

--HG--
extra : transplant_source : %E0%D0%C5%8B%BEU%DD%24%5D7%1F%ADV%AD%EB%23%CBU%80%EB

Update FSF address on non-contributed code and COPYING files.

2007-11-09T17:11:05+00:00

For contributed code, leave whatever the version we last synced for is using
to make simpler future syncs.

Workaround for recent glibc & -D_FORTIFY_SOURCE=2 (defines open() as a macro).

2007-08-15T15:38:46+00:00

According to bug 1773769, this breaks foo->open().
The fix (as used in Ville Skyttä's patch, which doesn't cover all cases) is
to replace this with (foo->open)().

This patch was generated using
sed -i -re 's/(([[:alnum:]_]+(->|\.))+open) ?\(/(\1) (/' `grep '[>.]open \?(' include -rIl`
One change (in a comment) is not committed.

Fix goom visualization plug-in

2007-08-12T17:31:37+00:00

I noticed that goom visualization plug-in doesn't work / freezes at some
combination of bit rates and its FPS.

Digging through it I found that algorithm that dispatches sound data to goom
is buggy, and so I have rewrote/cleaned  it a lot.

Let me explain what is wrong:

I am talking about goom_port_put_buffer
in /xine-lib-1.1.7/src/post/goom/xine_goom.c

The counter this->skip_frame is supposed to hold count of frames that goom
should skip because of _video render unable to render video_.
But that algorithm also skips frames on its own, and still decrements that
counter.

So it goes negative, and no frames are displayed.

Basically to fix that you need to add
if (this->skip_frame > 0)
before this->skip_frame--;

But since I want to fix that properly I decided to learn why goom skips frames
on its own, and I now understand that whole algorithm is buggy.

Thus I reimplemented it properly.
I tested it , and it works with all my sound files, also I added lot of debug
printfs to test whenever it works as expected, and it does.

--HG--
extra : transplant_source : %B6%0C%09%D6%93%B8%00cj%3B8%C7%B5%0B%DB%21%08%92%3E%7B

Add $(LTLIBINTL) wherever objdump -R shows a dependency on gettext functions.

2007-06-09T16:59:03+00:00

Some plugins may have been missed due to them not being built here.