summaryrefslogtreecommitdiff
path: root/src/xine-utils
diff options
context:
space:
mode:
authorFrantišek Dvořák <valtri@users.sourceforge.net>2006-04-05 22:12:17 +0000
committerFrantišek Dvořák <valtri@users.sourceforge.net>2006-04-05 22:12:17 +0000
commit639bd610bfcb1a028b91a5c3d125045c8de6d8b7 (patch)
tree6247df0c3a36b4a8eb11e0a764ff3e99632a619b /src/xine-utils
parent22924ef0924502e0d9b1652651d40270602ee7a0 (diff)
downloadxine-lib-639bd610bfcb1a028b91a5c3d125045c8de6d8b7.tar.gz
xine-lib-639bd610bfcb1a028b91a5c3d125045c8de6d8b7.tar.bz2
1) various warning fixes
2) [coverity] fixes: - 279 (w32): test should be on input parametr type, not typeW - 267 (aout): can be ignored but there was warning anyway - 234 (w32): missing free on error & exit - 152 (w32): missing free on error & exit - 148 (w32): fixed bound of static array in test - 101 (ffdec): defense code when avodec_encode_video will fail (just defense to the future, should never happen with current ffmpeg in xine) - 98, 99 (w32): check negative handle by _x_assert (it's used as index to array) - 90 (w32): negate pointer check (+added check for size) - 89 (w32): added NULL and size check CVS patchset: 7959 CVS date: 2006/04/05 22:12:17
Diffstat (limited to 'src/xine-utils')
-rw-r--r--src/xine-utils/list.c4
-rw-r--r--src/xine-utils/list.h4
-rw-r--r--src/xine-utils/ring_buffer.c6
3 files changed, 7 insertions, 7 deletions
diff --git a/src/xine-utils/list.c b/src/xine-utils/list.c
index 88de77fda..6d5d876bf 100644
--- a/src/xine-utils/list.c
+++ b/src/xine-utils/list.c
@@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
*
- * $Id: list.c,v 1.10 2006/01/27 07:46:16 tmattern Exp $
+ * $Id: list.c,v 1.11 2006/04/05 22:12:20 valtri Exp $
*
*/
@@ -138,7 +138,7 @@ static void xine_list_recycle_elem(xine_list_t *list, xine_list_elem_t *elem) {
}
/* List constructor */
-xine_list_t *xine_list_new() {
+xine_list_t *xine_list_new(void) {
xine_list_t *new_list;
new_list = (xine_list_t*)malloc(sizeof(xine_list_t));
diff --git a/src/xine-utils/list.h b/src/xine-utils/list.h
index 57f131642..5b5f3532e 100644
--- a/src/xine-utils/list.h
+++ b/src/xine-utils/list.h
@@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
*
- * $Id: list.h,v 1.2 2006/01/27 07:46:16 tmattern Exp $
+ * $Id: list.h,v 1.3 2006/04/05 22:12:20 valtri Exp $
*
* Doubly-linked linked list.
*
@@ -50,7 +50,7 @@ typedef struct xine_list_s xine_list_t;
typedef void* xine_list_iterator_t;
/* Constructor */
-xine_list_t *xine_list_new();
+xine_list_t *xine_list_new(void);
/* Destructor */
void xine_list_delete(xine_list_t *list);
diff --git a/src/xine-utils/ring_buffer.c b/src/xine-utils/ring_buffer.c
index 9fe14f30f..a98e1f261 100644
--- a/src/xine-utils/ring_buffer.c
+++ b/src/xine-utils/ring_buffer.c
@@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
*
- * $Id: ring_buffer.c,v 1.2 2006/01/27 19:37:15 tmattern Exp $
+ * $Id: ring_buffer.c,v 1.3 2006/04/05 22:12:20 valtri Exp $
*
*/
#ifdef HAVE_CONFIG_H
@@ -44,14 +44,14 @@ struct xine_ring_buffer_chunk_s {
};
/* init */
-void xine_ring_buffer_chunk_create(void *object) {
+static void xine_ring_buffer_chunk_create(void *object) {
xine_ring_buffer_chunk_t *chunk = (xine_ring_buffer_chunk_t *)object;
chunk->mem = NULL;
chunk->size = 0;
}
/* cleanup */
-void xine_ring_buffer_chunk_return(void *object) {
+static void xine_ring_buffer_chunk_return(void *object) {
xine_ring_buffer_chunk_t *chunk = (xine_ring_buffer_chunk_t *)object;
chunk->mem = NULL;
chunk->size = 0;