summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2007-06-03Add a comment & changelog entry for the mmap bug fix.Darren Salt
2007-06-03[patch] Nasty mmap problem with huge filesAndrew de Quincey
Hi, I've been tracking down a very odd bug this afternoon. As it turns out it is caused by enabling xine's mmap() support for the input_file.c. I'm running 32 bit linux 2.6.21. The file in question is 0x10e4da000 bytes long (you can probably guess what kind of bug this is by now :) Anyway, the issue stems from the definition of mmap(): void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset); compare this to the definition of st_size in struct stat: off_t st_size; /* total size, in bytes */ On my machine (in input_file.c) sizeof(size_t) ==4, whilst sizeof(off_t) == 8. However the compiler doesn't generate a warning when the following is done in xine's code: if ( (this->mmap_base = mmap(NULL, sbuf.st_size, PROT_READ, MAP_SHARED, this->fh, 0)) != (void*)-1 So it silently truncates the upper part of the length. Obviously you cannot mmap() a file that large into (32 bit) memory anyway, but as it turns out, mmapping() 0xe4da000 succeeds, which causes... problems. The patch (against xine-lib 1.1.6) does two things: * Check that the length will not be truncated, while still allowing for mmap()s of large files under 64 bit OSes. * A correctness fix: if mmap() fails, this->mmap_base will be set to 0xffffffff. Later on when the file is closed, this means it was attempting to do munmap(0xffffffff).
2007-06-02Rename the files.Diego 'Flameeyes' Pettenò
2007-06-02Convert the rule too.Diego 'Flameeyes' Pettenò
2007-06-02Convert the figure files to SVG (with white background).Diego 'Flameeyes' Pettenò
2007-06-02Fix && -> &&Diego 'Flameeyes' Pettenò
2007-06-02Don't check for sgmltools and fig2dev.Diego 'Flameeyes' Pettenò
2007-06-02Reorder hackersguidedir.Diego 'Flameeyes' Pettenò
2007-06-02Remove docs target.Diego 'Flameeyes' Pettenò
2007-06-02Remove dist-hook.Diego 'Flameeyes' Pettenò
2007-06-02Replace the faq.html and faq.txt rules with new ones with xmlto.Diego 'Flameeyes' Pettenò
2007-06-02Rename the file in EXTRA_DIST.Diego 'Flameeyes' Pettenò
2007-06-02Rename the faq SGML file to DocBook.Diego 'Flameeyes' Pettenò
--HG-- rename : doc/faq/faq.sgml => doc/faq/faq.docbook
2007-06-02Replace the distclean-local hook with a proper DISTCLEANFILES usage.Diego 'Flameeyes' Pettenò
2007-06-02Remove docs-prepare target.Diego 'Flameeyes' Pettenò
2007-06-02Remove the dist-hook.Diego 'Flameeyes' Pettenò
2007-06-02Update copyright year.Diego 'Flameeyes' Pettenò
2007-06-02Update the doctype to DocBook XML.Diego 'Flameeyes' Pettenò
2007-06-02Assume presence of fig2dev command while doing make dist or make install ↵Diego 'Flameeyes' Pettenò
from Hg.
2007-06-02Add a new rule to build hackersguide.html from the docbook version.Diego 'Flameeyes' Pettenò
2007-06-02Make LIBNAME correspond to the soname.Darren Salt
2007-06-02Make the docbook valid XML.Diego 'Flameeyes' Pettenò
2007-06-02Add missing line.Diego 'Flameeyes' Pettenò
2007-06-02Don't create a distclean-local hook when you can just use DISTCLEANFILES ↵Diego 'Flameeyes' Pettenò
variable.
2007-06-02Remove the copy of original sgml files.Diego 'Flameeyes' Pettenò
2007-06-02Rename the .sgml to .docbook.Diego 'Flameeyes' Pettenò
2007-06-02Update copyright year and add my name to authors.Diego 'Flameeyes' Pettenò
2007-06-02Use UTF-8 encoding.Diego 'Flameeyes' Pettenò
2007-06-02Update the doctype and rename entities.Diego 'Flameeyes' Pettenò
2007-06-02Rename the sgml files to docbook (xml).Diego 'Flameeyes' Pettenò
--HG-- rename : doc/hackersguide/hackersguide.sgml => doc/hackersguide/hackersguide.docbook rename : doc/hackersguide/internals.sgml => doc/hackersguide/internals.docbook rename : doc/hackersguide/intro.sgml => doc/hackersguide/intro.docbook rename : doc/hackersguide/library.sgml => doc/hackersguide/library.docbook rename : doc/hackersguide/output.sgml => doc/hackersguide/output.docbook rename : doc/hackersguide/overview.sgml => doc/hackersguide/overview.docbook rename : doc/hackersguide/stream.sgml => doc/hackersguide/stream.docbook
2007-06-02Fiddle with the versioning so that we get libxine.so.2.0.0.Darren Salt
This requires renaming po/libxine1.pot -> po/libxine2.pot. --HG-- rename : po/libxine1.pot => po/libxine2.pot
2007-06-02Repair breakage introduced in cset 923cae943a0e.Darren Salt
2007-06-02Rename libxine-dev to libxine2-dev.Darren Salt
--HG-- rename : debian/libxine-dev.install => debian/libxine2-dev.install
2007-06-02Merge.Darren Salt
2007-06-02Merge from 1.1; handle Debian packaging fallout from the merge.Darren Salt
--HG-- rename : debian/libxine1-doc.docs => debian/libxine2-doc.docs rename : debian/libxine1-doc.manpages => debian/libxine2-doc.manpages
2007-06-02Conflict with libxine2-dev.Darren Salt
2007-06-02Bump libtool revision number.Darren Salt
2007-06-02Don't use GNU make extensions for fig to png creation, as the old-style ↵Diego 'Flameeyes' Pettenò
suffix rules works.
2007-06-02Regenerate.Diego 'Flameeyes' Pettenò
2007-06-02Add a -doc package, allowing libxine1 and libxine2 to be installed together.Darren Salt
2007-06-01Remove cachedir_entry variable that is now unused.Diego 'Flameeyes' Pettenò
2007-06-01Collapse the Ogg demuxer, and the Theora, Vorbis and Speex decoders in the ↵Diego 'Flameeyes' Pettenò
same 'xiph' plugin. As the three decoders requires Ogg support, and requires an Ogg demuxer to play, enabling any one of them will then enable the ogg demuxer. The Ogg demuxer, on its own, needs to know which of the three formats are enabled, or it will not be able to properly decode them. With this change, only one plugin will need to load and know about Xiph formats and libraries. --HG-- rename : src/demuxers/demux_ogg.c => src/combined/xine_ogg_demuxer.c rename : src/libxineadec/xine_speex_decoder.c => src/combined/xine_speex_decoder.c rename : src/libxinevdec/xine_theora_decoder.c => src/combined/xine_theora_decoder.c rename : src/libxineadec/xine_vorbis_decoder.c => src/combined/xine_vorbis_decoder.c
2007-06-01Port Simon Farnsworth's xv deinterlacing fix to xcbxv.Darren Salt
2007-06-01Prioritise the musepack demuxer over mpgaudio, as sometimes the latter can ↵Bram Verweij
misfire and report a good file as unplayable.
2007-05-31Merge.Diego 'Flameeyes' Pettenò
2007-05-31Don't include the local copy of frame.h and synth.h when building with ↵Diego 'Flameeyes' Pettenò
external libmad.
2007-05-31Move gsm610 sources inside contrib/.Diego 'Flameeyes' Pettenò
--HG-- rename : src/libxineadec/gsm610/Makefile.am => contrib/gsm610/Makefile.am rename : src/libxineadec/gsm610/add.c => contrib/gsm610/add.c rename : src/libxineadec/gsm610/decode.c => contrib/gsm610/decode.c rename : src/libxineadec/gsm610/gsm.h => contrib/gsm610/gsm.h rename : src/libxineadec/gsm610/gsm_config.h => contrib/gsm610/gsm_config.h rename : src/libxineadec/gsm610/gsm_create.c => contrib/gsm610/gsm_create.c rename : src/libxineadec/gsm610/gsm_decode.c => contrib/gsm610/gsm_decode.c rename : src/libxineadec/gsm610/gsm_destroy.c => contrib/gsm610/gsm_destroy.c rename : src/libxineadec/gsm610/long_term.c => contrib/gsm610/long_term.c rename : src/libxineadec/gsm610/lpc.c => contrib/gsm610/lpc.c rename : src/libxineadec/gsm610/private.h => contrib/gsm610/private.h rename : src/libxineadec/gsm610/proto.h => contrib/gsm610/proto.h rename : src/libxineadec/gsm610/rpe.c => contrib/gsm610/rpe.c rename : src/libxineadec/gsm610/short_term.c => contrib/gsm610/short_term.c rename : src/libxineadec/gsm610/table.c => contrib/gsm610/table.c rename : src/libxineadec/gsm610/unproto.h => contrib/gsm610/unproto.h
2007-05-31Move modplug demuxing on its own plugin.Diego 'Flameeyes' Pettenò
This way binary distributions can make it optional, as it requires quite a bit of CPU time during initialisation, even for audio files that nothing have to do with modplug.
2007-05-31Patch: fix parsing qt/mov embedded referncesClaudio Ciccani
The attached patch fixes a problem with embedded references in recent versions of quicktime's movie formats. Apparently there is an additional atom (RMRA) before the RMDA atom: it works like a container for all subsequent atoms, so it can be safely skipped. You can test yourself what I'm saying by watching some trailers at apple.com (http://www.apple.com/trailers). -- Regards, Claudio Ciccani klan@users.sf.net http://directfb.org http://sf.net/projects/php-directfb
2007-05-31Return -1 in case the mode is not one of the accepted ones.Diego 'Flameeyes' Pettenò
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-23 01:55:32 +0000