| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This requires that many other files include config.h themselves.
Also convert <config.h> to "config.h".
|
|
|
|
Use the proper function for common memory operations (memset() for
zeroing, memcpy() for copying, memmove() for moving), instead of
looping through arrays.
By extension, remove loops to reset arrays when they were allocated
with calloc() and thus already zeroed.
|
|
Whenever an allocated memory area is immediately filled in with a
string through strcpy() or strncpy(), replace the calls with the
appropriate strn?dup().
|
|
|
|
The xine_xmalloc() function is going to be deprecated, as its
behaviour is rarely needed as such, and it's thus misused.
With this, almost all uses of xine_xmalloc() with static size (for
instance the value returned by sizeof()) or with a size that is
guaranteed not to be zero (like strlen()+1) are replaced with calls to
either calloc(1, ...) or malloc().
malloc() is used whenever the allocated memory is going to be
immediately overwritten, while calloc() is used in every other case,
as it sets the whole memory area to zero.
--HG--
extra : transplant_source : %8F%98%EC%02%1E%83%F0s%06X%83C%205Y%80%B12%CC%E1
|
|
Functions and data structures that are not exported and are only ever
used in the same unit they are defined should be marked static to
improve compiler's ability to optimise them.
This applies to xine_dispose_internal() function for xine-lib, the
extended_to_int() function in the AIFF demuxer, the bandwidths array
in QuickTime demuxer, the wc_pal_lookup table in the WC3 movie
demuxer, and the rm_header and pnm_data_header arrays in pnm input
plugin.
|
|
--HG--
extra : transplant_source : %E0%D0%C5%8B%BEU%DD%24%5D7%1F%ADV%AD%EB%23%CBU%80%EB
|
|
For contributed code, leave whatever the version we last synced for is using
to make simpler future syncs.
|
|
Two of the modified files are headers, but each contains definitions as well as
declarations and is only ever used once.
|
|
CVS patchset: 8065
CVS date: 2006/06/20 01:46:41
|
|
(thanks iDEFENSE for reporting these)
CVS patchset: 7258
CVS date: 2004/12/15 12:53:35
|
|
CVS patchset: 5896
CVS date: 2003/12/12 22:53:15
|
|
CVS patchset: 5879
CVS date: 2003/12/09 00:02:28
|
|
relevant too. Small other little fix (can't remember). Change few internal function prototype because it xine_t pointer need to be used if some xine's internal sections. NOTE: libdvd{nav,read} is still too noisy, i will take a look to made it quit, without invasive changes. To be continued...
CVS patchset: 5844
CVS date: 2003/12/05 15:54:56
|
|
CVS patchset: 5796
CVS date: 2003/11/26 19:43:26
|
|
CVS patchset: 5721
CVS date: 2003/11/11 18:44:50
|
|
pnm servers. Fixes:
pnm://rm.content.loudeye.com/~a-600111/0651022_0101_00_0002.ra
CVS patchset: 5076
CVS date: 2003/06/20 16:17:28
|
|
CVS patchset: 4603
CVS date: 2003/04/13 18:49:12
|
|
All assert() function calls, with exceptions of libdvdread and libdvdnav, have been
replaced with XINE_ASSERT. Functionally XINE_ASSERT behaves just likes its predecesor but its
adding the ability to print out a stack trace at the point where the assertion fails.
So here are a few examples.
assert (0);
This use of assert was found in a couple locations most favorably being the default case of a switch
statement. This was the only thing there. So if the switch statement was unable to find a match
it would have defaulted to this and the user and the developers would be stuck wonder who died and where.
So it has been replaced with
XINE_ASSERT(0, "We have reach this point and don't have a default case");
It may seem a bit none descriptive but there is more going on behind the scene.
In addition to checking a condition is true/false, in this case '0', the XINE_ASSERT
prints out:
<filename>:<function name>:<line number> - assertion '<assertion expression>' failed. <description>
An example of this might be:
input_dvd.c:open_plugin:1178 - assertion '0' failed. xine_malloc failed!!! You have run out of memory
XINE_ASSERT and its helper function, print_trace, are found in src/xine-utils/xineutils.h
CVS patchset: 4301
CVS date: 2003/02/28 02:51:47
|
|
select() is useful to avoid burning cpu cicles, otoh, we should not
call it after end of stream since it will hang xine for 30sec.
idea: do select() only on EAGAIN.
todo: unify these functions (?)
CVS patchset: 4105
CVS date: 2003/02/05 00:08:55
|
|
- new fb driver with zero copy
CVS patchset: 4058
CVS date: 2003/01/31 14:06:03
|
|
CVS patchset: 3989
CVS date: 2003/01/22 16:33:23
|
|
CVS patchset: 3855
CVS date: 2003/01/10 20:57:11
|
|
CVS patchset: 3685
CVS date: 2002/12/26 20:30:00
|
|
CVS patchset: 3683
CVS date: 2002/12/26 14:57:33
|
|
CVS patchset: 3623
CVS date: 2002/12/22 00:35:04
|
|
55&atid=109655
CVS patchset: 3566
CVS date: 2002/12/16 23:29:59
|
|
- removing exit()s from pnm.c
- server error message retrieving fixed in pnm.c
- handling of server messages in rtsp
CVS patchset: 3564
CVS date: 2002/12/16 21:50:54
|
|
turned off all non-error messages, much easier mrl parsing.
CVS patchset: 3531
CVS date: 2002/12/15 01:34:56
|
|
only a few streams work for now.
* A couple of fixes in pnm input plugin.
* Fixed stream info in demux_real.
CVS patchset: 3495
CVS date: 2002/12/12 22:08:09
|
|
CVS patchset: 3347
CVS date: 2002/11/23 00:04:32
|
