| Age | Commit message (Collapse) | Author |
|---|
|
libdvdnav into the spu decoder plugin statically, only nav_read.c is needed
(read: revert to old linking behaviour for included libdvdnav)
* beautification
CVS patchset: 4724
CVS date: 2003/04/30 16:49:33
|
|
The problem arises because of inconsistent usage of libdvdread's functions regarding
NAV packet reading: libspudec and the dxr3 spu decoder use some of these functions,
but they used to have private copies of the relevant files of libdvdread. These do
not work any more now, since the internal layout of NAV packets in libdvdread
changed lately. So we should always use the functions from current libdvdread.
Please note that highlights might not work yet.
The next step will be to sync libdvdnav. Stay tuned.
CVS patchset: 4371
CVS date: 2003/03/08 14:11:52
|
|
All assert() function calls, with exceptions of libdvdread and libdvdnav, have been
replaced with XINE_ASSERT. Functionally XINE_ASSERT behaves just likes its predecesor but its
adding the ability to print out a stack trace at the point where the assertion fails.
So here are a few examples.
assert (0);
This use of assert was found in a couple locations most favorably being the default case of a switch
statement. This was the only thing there. So if the switch statement was unable to find a match
it would have defaulted to this and the user and the developers would be stuck wonder who died and where.
So it has been replaced with
XINE_ASSERT(0, "We have reach this point and don't have a default case");
It may seem a bit none descriptive but there is more going on behind the scene.
In addition to checking a condition is true/false, in this case '0', the XINE_ASSERT
prints out:
<filename>:<function name>:<line number> - assertion '<assertion expression>' failed. <description>
An example of this might be:
input_dvd.c:open_plugin:1178 - assertion '0' failed. xine_malloc failed!!! You have run out of memory
XINE_ASSERT and its helper function, print_trace, are found in src/xine-utils/xineutils.h
CVS patchset: 4301
CVS date: 2003/02/28 02:51:47
|
|
- libdvdread already checks them
- at least one (really broken) dvd I have here doesn't like them
CVS patchset: 2342
CVS date: 2002/07/23 10:03:23
|
|
CVS patchset: 1775
CVS date: 2002/04/25 12:55:47
|
|
CVS patchset: 1330
CVS date: 2002/01/03 23:56:44
|
