From 240889c0d0a7ead9df29c5d154403490fb09e8c7 Mon Sep 17 00:00:00 2001 From: Darren Salt Date: Sun, 5 Apr 2009 02:36:17 +0100 Subject: Properly NUL-terminate when reading ID3v2.2 tag content. --- ChangeLog | 1 + src/demuxers/id3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/ChangeLog b/ChangeLog index 999df63b8..7c37a8a48 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,6 +3,7 @@ xine-lib (1.1.17) 2009-??-?? * Add support for sndio (OpenBSD sound API). * Correct invalid MIME info in the MOD demuxer. * Fix a resource leak in libdvdnav. + * Properly NUL-terminate when reading ID3v2.2 tag content. xine-lib (1.1.16.3) 2009-04-03 * Security fixes: diff --git a/src/demuxers/id3.c b/src/demuxers/id3.c index c6f261468..1aebbc817 100644 --- a/src/demuxers/id3.c +++ b/src/demuxers/id3.c @@ -286,6 +286,7 @@ static int id3v22_interp_frame(input_plugin_t *input, } if (input->read (input, buf, frame_header->size) == frame_header->size) { + buf[frame_header->size] = 0; enc = buf[0]; if( enc >= ID3_ENCODING_COUNT ) enc = 0; -- cgit v1.2.3