From 8eae9306239d6683d7cd06bf92be02bbd1c43865 Mon Sep 17 00:00:00 2001 From: Darren Salt Date: Sat, 9 Jun 2012 15:38:03 +0100 Subject: Fix a possible NULL dereference when cleaning up in the FFT vis plugin code. --- ChangeLog | 1 + src/post/visualizations/fft.c | 11 +++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 16ba11b74..9e765ed92 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,6 @@ xine-lib (1.1.21) ????-??-?? * Fix a potential double-free (goom) when playing AAC files. + * Fix a possible clean-up crash in the goom FFT code. * Fix matroska header compression. * MPEG-TS fixes and enhancements * Improved syncing of DVB subtitles diff --git a/src/post/visualizations/fft.c b/src/post/visualizations/fft.c index 7e32dbbf6..ac109e379 100644 --- a/src/post/visualizations/fft.c +++ b/src/post/visualizations/fft.c @@ -153,10 +153,13 @@ fft_t *fft_new (int bits) void fft_dispose(fft_t *fft) { - free(fft->SineTable); - free(fft->CosineTable); - free(fft->WinTable); - free(fft); + if (fft) + { + free(fft->SineTable); + free(fft->CosineTable); + free(fft->WinTable); + free(fft); + } } /* -- cgit v1.2.3