From 80aa47e9de7f9d6f819d11821669ced45682e903 Mon Sep 17 00:00:00 2001 From: Darren Salt Date: Mon, 6 Apr 2009 01:50:51 +0100 Subject: A trivial harmless little length test off-by-one. --- src/demuxers/id3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/demuxers/id3.c b/src/demuxers/id3.c index 0d0ee7231..39055a852 100644 --- a/src/demuxers/id3.c +++ b/src/demuxers/id3.c @@ -276,7 +276,7 @@ static int id3v22_interp_frame(input_plugin_t *input, char *buf; int enc; const size_t bufsize = frame_header->size + 2; - if ( bufsize <= 3 ) /* frames has to be _at least_ 1 byte */ + if ( bufsize < 3 ) /* frames has to be _at least_ 1 byte */ return 0; buf = malloc(bufsize); @@ -474,7 +474,7 @@ static int id3v23_interp_frame(input_plugin_t *input, char *buf; int enc; const size_t bufsize = frame_header->size + 2; - if ( bufsize <= 3 ) /* frames has to be _at least_ 1 byte */ + if ( bufsize < 3 ) /* frames has to be _at least_ 1 byte */ return 0; buf = malloc(bufsize); @@ -729,7 +729,7 @@ static int id3v24_interp_frame(input_plugin_t *input, char *buf; int enc; const size_t bufsize = frame_header->size + 2; - if ( bufsize <= 3 ) /* frames has to be _at least_ 1 byte */ + if ( bufsize < 3 ) /* frames has to be _at least_ 1 byte */ return 0; buf = malloc(bufsize); -- cgit v1.2.3 From 27f977bbfde5a35481e9e564864fdf4cff27807d Mon Sep 17 00:00:00 2001 From: Darren Salt Date: Fri, 10 Apr 2009 18:29:19 +0100 Subject: Add advisory nos. for the QT demuxer bug. --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 365077ee7..2322780e2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,7 @@ xine-lib (1.1.16.3) 2009-04-03 - Fix another possible int overflow in the 4XM demuxer. (ref. TKADV2009-004, CVE-2009-0698) - Fix an integer overflow in the Quicktime demuxer. + (TKADV2009-005, CVE-2009-1274) * Enable libmpeg2new (if configured with --enable-libmpeg2new). This is not yet production code; the old mpeg2 decoder remains the default. * Add support for OpenBSD. -- cgit v1.2.3