From a39a950269d165f18448cc7d6da691bf14b9e03b Mon Sep 17 00:00:00 2001 From: Chris Rankin Date: Mon, 3 Oct 2011 12:38:45 +0100 Subject: Prefix open_cloexec() and create_cloexec() with xine_, and add new xine_socket_cloexec() function. --- src/input/input_net.c | 32 +++----------------------------- 1 file changed, 3 insertions(+), 29 deletions(-) (limited to 'src/input/input_net.c') diff --git a/src/input/input_net.c b/src/input/input_net.c index f44db8301..edbe73b08 100644 --- a/src/input/input_net.c +++ b/src/input/input_net.c @@ -115,25 +115,13 @@ static int host_connect_attempt_ipv4(struct in_addr ia, int port, xine_t *xine) int s; struct sockaddr_in sin; - s = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP); + s = xine_socket_cloexec(PF_INET, SOCK_STREAM, IPPROTO_TCP); if (s==-1) { xine_log(xine, XINE_LOG_MSG, _("input_net: socket(): %s\n"), strerror(errno)); return -1; } -#ifndef WIN32 - if (fcntl(s, F_SETFD, FD_CLOEXEC) < 0) { - xine_log(xine, XINE_LOG_MSG, - _("input_net: Failed to make socket uninheritable (%s)\n"), - strerror(errno)); - } -#else - if (!SetHandleInformation((HANDLE)s, HANDLE_FLAG_INHERIT, 0)) { - xine_log(xine, XINE_LOG_MSG, "Failed to make socket uninheritable\n"); - } -#endif - sin.sin_family = AF_INET; sin.sin_addr = ia; sin.sin_port = htons(port); @@ -155,27 +143,13 @@ static int host_connect_attempt_ipv4(struct in_addr ia, int port, xine_t *xine) #else static int host_connect_attempt(int family, struct sockaddr* sin, int addrlen, xine_t *xine) { - int s; - - s = socket(family, SOCK_STREAM, IPPROTO_TCP); - if (s==-1) { + int s = xine_socket_cloexec(family, SOCK_STREAM, IPPROTO_TCP); + if (s == -1) { xine_log(xine, XINE_LOG_MSG, _("input_net: socket(): %s\n"), strerror(errno)); return -1; } -#ifndef WIN32 - if (fcntl(s, F_SETFD, FD_CLOEXEC) < 0) { - xine_log(xine, XINE_LOG_MSG, - _("input_net: Failed to make socket uninheritable (%s)\n"), - strerror(errno)); - } -#else - if (!SetHandleInformation((HANDLE)s, HANDLE_FLAG_INHERIT, 0)) { - xine_log(xine, XINE_LOG_MSG, "Failed to make socket uninheritable\n"); - } -#endif - #ifndef WIN32 if (connect(s, sin, addrlen)==-1 && errno != EINPROGRESS) #else -- cgit v1.2.3