From 3736bbc56bd4cf5b0326a2d14a370f11e58ead83 Mon Sep 17 00:00:00 2001 From: Matt Messier Date: Tue, 8 May 2007 00:03:41 -0400 Subject: RIP: AC_OPTIMIZATIONS -- Removed m4/optimizations.m4, and along with it, AC_OPTIMIZATIONS. -- Stripped down, cleaned up, and merged the former together with other compiler characteristic checks. -- Do not set any optimization flags into CFLAGS. Update all Makefile.am's with proper AM_CFLAGS, AM_CPPFLAGS, AM_LDFLAGS, etc. to set up optimization flags, usually from DEFAULT_OCFLAGS. -- Start cleaning up CFLAGS/CPPFLAGS stuff in Makefile.am's all over the place. -- Correct a number of places where CFLAGS itself was being mangled in Makefile to on-the-fly adjust optimizations to work around compiler bugs. This stuff is now done correctly. -- The run of automake from autogen.sh is now clean of warnings. -- Cleaned out some (now) dead macros from m4/_xine.m4 -- Mac OS X intel builds out-of-the-box now -- dropped optimization on post/deinterlace/plugins/kdetv-greedyh to O1_CFLAGS. -- OBJCFLAGS is now getting set correctly everywhere that it needs to be -- Various other miscellaneous cleanups all over --- src/input/librtsp/Makefile.am | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/input/librtsp') diff --git a/src/input/librtsp/Makefile.am b/src/input/librtsp/Makefile.am index bb85f9cf4..9027ab260 100644 --- a/src/input/librtsp/Makefile.am +++ b/src/input/librtsp/Makefile.am @@ -1,6 +1,8 @@ include $(top_srcdir)/misc/Makefile.common +AM_CFLAGS = $(DEFAULT_OCFLAGS) $(VISIBILITY_FLAG) AM_CPPFLAGS = -D_LARGEFILE64_SOURCE -I$(srcdir)/../libreal +AM_LDFLAGS = $(xineplug_ldflags) noinst_LTLIBRARIES = librtsp.la @@ -8,9 +10,6 @@ librtsp_la_SOURCES = \ rtsp.c \ rtsp_session.c -librtsp_la_CFLAGS = $(VISIBILITY_FLAG) -librtsp_la_LDFLAGS = -avoid-version -module - noinst_HEADERS = \ rtsp.h \ rtsp_session.h -- cgit v1.2.3 From 68a59d5714f4cf1ac536d347c879995fb4685475 Mon Sep 17 00:00:00 2001 From: Matt Messier Date: Thu, 10 May 2007 14:16:59 -0400 Subject: Remove -D_LARGEFILE64_SOURCE from AM_CPPFLAGS This is a transitional macro that's normally defined by the system includes if _GNU_SOURCE is defined, which it will be because of AC_GNU_SOURCE. It's only used by GNU libc. I cannot find anything in any of the code built by these Makefiles that uses any of the types, structures, or functions that defining this macro produces. --- src/input/librtsp/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/input/librtsp') diff --git a/src/input/librtsp/Makefile.am b/src/input/librtsp/Makefile.am index 9027ab260..0df52d3aa 100644 --- a/src/input/librtsp/Makefile.am +++ b/src/input/librtsp/Makefile.am @@ -1,7 +1,7 @@ include $(top_srcdir)/misc/Makefile.common AM_CFLAGS = $(DEFAULT_OCFLAGS) $(VISIBILITY_FLAG) -AM_CPPFLAGS = -D_LARGEFILE64_SOURCE -I$(srcdir)/../libreal +AM_CPPFLAGS = -I$(srcdir)/../libreal AM_LDFLAGS = $(xineplug_ldflags) noinst_LTLIBRARIES = librtsp.la -- cgit v1.2.3 From 913f9b8ee348c91717cdf5cd4c8a4d56b9d22a5e Mon Sep 17 00:00:00 2001 From: Matt Messier Date: Fri, 11 May 2007 18:24:25 -0400 Subject: Another pass at cleaning up Makefile.am files. More to come. --- src/input/librtsp/Makefile.am | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) (limited to 'src/input/librtsp') diff --git a/src/input/librtsp/Makefile.am b/src/input/librtsp/Makefile.am index 0df52d3aa..68d554c2c 100644 --- a/src/input/librtsp/Makefile.am +++ b/src/input/librtsp/Makefile.am @@ -1,15 +1,10 @@ include $(top_srcdir)/misc/Makefile.common -AM_CFLAGS = $(DEFAULT_OCFLAGS) $(VISIBILITY_FLAG) -AM_CPPFLAGS = -I$(srcdir)/../libreal -AM_LDFLAGS = $(xineplug_ldflags) +AM_CFLAGS = $(DEFAULT_OCFLAGS) $(VISIBILITY_FLAG) +AM_CPPFLAGS = -I$(top_srcdir)/src/input/libreal -noinst_LTLIBRARIES = librtsp.la +noinst_HEADERS = rtsp.h rtsp_session.h -librtsp_la_SOURCES = \ - rtsp.c \ - rtsp_session.c +noinst_LTLIBRARIES = librtsp.la -noinst_HEADERS = \ - rtsp.h \ - rtsp_session.h +librtsp_la_SOURCES = rtsp.c rtsp_session.c -- cgit v1.2.3