From 49327f43ca2196122a60314e67eeee929efea873 Mon Sep 17 00:00:00 2001 From: Stephen Torri Date: Fri, 28 Feb 2003 02:51:47 +0000 Subject: Xine assert() replacement: All assert() function calls, with exceptions of libdvdread and libdvdnav, have been replaced with XINE_ASSERT. Functionally XINE_ASSERT behaves just likes its predecesor but its adding the ability to print out a stack trace at the point where the assertion fails. So here are a few examples. assert (0); This use of assert was found in a couple locations most favorably being the default case of a switch statement. This was the only thing there. So if the switch statement was unable to find a match it would have defaulted to this and the user and the developers would be stuck wonder who died and where. So it has been replaced with XINE_ASSERT(0, "We have reach this point and don't have a default case"); It may seem a bit none descriptive but there is more going on behind the scene. In addition to checking a condition is true/false, in this case '0', the XINE_ASSERT prints out: :: - assertion '' failed. An example of this might be: input_dvd.c:open_plugin:1178 - assertion '0' failed. xine_malloc failed!!! You have run out of memory XINE_ASSERT and its helper function, print_trace, are found in src/xine-utils/xineutils.h CVS patchset: 4301 CVS date: 2003/02/28 02:51:47 --- src/libspudec/spu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/libspudec/spu.c') diff --git a/src/libspudec/spu.c b/src/libspudec/spu.c index 92a02228b..069632a22 100644 --- a/src/libspudec/spu.c +++ b/src/libspudec/spu.c @@ -35,7 +35,7 @@ * along with this program; see the file COPYING. If not, write to * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. * - * $Id: spu.c,v 1.60 2003/02/20 18:09:10 siggi Exp $ + * $Id: spu.c,v 1.61 2003/02/28 02:51:50 storri Exp $ * */ @@ -224,7 +224,7 @@ void spudec_decode_nav(spudec_decoder_t *this, buf_element_t *buf) { /* FIXME: Add command copying here */ break; default: - assert(0); + XINE_ASSERT(0, "We drop out here for some reason. Why no default behavior?"); break; } pthread_mutex_unlock(&this->nav_pci_lock); -- cgit v1.2.3