From 49327f43ca2196122a60314e67eeee929efea873 Mon Sep 17 00:00:00 2001 From: Stephen Torri Date: Fri, 28 Feb 2003 02:51:47 +0000 Subject: Xine assert() replacement: All assert() function calls, with exceptions of libdvdread and libdvdnav, have been replaced with XINE_ASSERT. Functionally XINE_ASSERT behaves just likes its predecesor but its adding the ability to print out a stack trace at the point where the assertion fails. So here are a few examples. assert (0); This use of assert was found in a couple locations most favorably being the default case of a switch statement. This was the only thing there. So if the switch statement was unable to find a match it would have defaulted to this and the user and the developers would be stuck wonder who died and where. So it has been replaced with XINE_ASSERT(0, "We have reach this point and don't have a default case"); It may seem a bit none descriptive but there is more going on behind the scene. In addition to checking a condition is true/false, in this case '0', the XINE_ASSERT prints out: :: - assertion '' failed. An example of this might be: input_dvd.c:open_plugin:1178 - assertion '0' failed. xine_malloc failed!!! You have run out of memory XINE_ASSERT and its helper function, print_trace, are found in src/xine-utils/xineutils.h CVS patchset: 4301 CVS date: 2003/02/28 02:51:47 --- src/xine-engine/lrb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/xine-engine/lrb.c') diff --git a/src/xine-engine/lrb.c b/src/xine-engine/lrb.c index c3be42039..63072472b 100644 --- a/src/xine-engine/lrb.c +++ b/src/xine-engine/lrb.c @@ -17,7 +17,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA * - * $Id: lrb.c,v 1.3 2002/10/23 17:12:31 guenter Exp $ + * $Id: lrb.c,v 1.4 2003/02/28 02:51:51 storri Exp $ * */ @@ -25,7 +25,6 @@ #include "config.h" #endif -#include #include "lrb.h" #include "xineutils.h" @@ -49,7 +48,7 @@ void lrb_drop (lrb_t *this) { buf_element_t *buf = this->oldest; - assert (buf); + XINE_ASSERT(buf, "Oldest buffer element is NULL"); this->oldest = buf->next; -- cgit v1.2.3