From 124347b154ae981d3a4997a4f98f7c3e620a673a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Franti=C5=A1ek=20Dvo=C5=99=C3=A1k?= Date: Sun, 26 Mar 2006 18:15:03 +0000 Subject: [coverity] Small change due to false positive: CID: 258 Checker: REVERSE_INULL (help) File: xine-lib/src/libw32dll/wine/win32.c Function: expRegOpenKeyA Description: Pointer "phkResult" dereferenced before NULL check Debug output fix: CID: 259 Checker: REVERSE_INULL (help) File: xine-lib/src/libw32dll/wine/win32.c Function: expSetFilePointer Description: Pointer "ext" dereferenced before NULL check CVS patchset: 7952 CVS date: 2006/03/26 18:15:03 --- src/libw32dll/wine/win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/libw32dll/wine/win32.c b/src/libw32dll/wine/win32.c index dcab43ea5..09ed78c32 100644 --- a/src/libw32dll/wine/win32.c +++ b/src/libw32dll/wine/win32.c @@ -1892,7 +1892,7 @@ static long WINAPI expRegSetValueExA(long key, const char* name, long v1, long v static long WINAPI expRegOpenKeyA (long hKey, LPCSTR lpSubKey, int* phkResult) { long result=RegOpenKeyExA(hKey, lpSubKey, 0, 0, phkResult); - dbgprintf("RegOpenKeyExA(key 0x%x, subkey '%s', 0x%x) => %d\n", + dbgprintf("RegOpenKeyExA(key 0x%x, subkey '%s', 0x%p) => %d\n", hKey, lpSubKey, phkResult, result); if(!result && phkResult) dbgprintf(" New key: 0x%x\n", *phkResult); return result; @@ -3631,7 +3631,7 @@ static WIN_BOOL WINAPI expWriteFile(HANDLE h,LPCVOID pv,DWORD size,LPDWORD wr,LP static DWORD WINAPI expSetFilePointer(HANDLE h, LONG val, LPLONG ext, DWORD whence) { int wh; - dbgprintf("SetFilePointer(%d, 0x%x, 0x%x = %d, %d)\n", h, val, ext, *ext, whence); + dbgprintf("SetFilePointer(%d, 0x%x, 0x%x = %d, %d)\n", h, val, ext, ext ? *ext : -1, whence); //why would DLL want temporary file with >2Gb size? switch(whence) { -- cgit v1.2.3