From 326a991366d9266bab8796016392fa217464b263 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Franti=C5=A1ek=20Dvo=C5=99=C3=A1k?= Date: Sun, 26 Mar 2006 17:20:11 +0000 Subject: [coverity] Fixed simple bug in destroying. CID: 260 Checker: REVERSE_INULL (help) File: xine-lib/src/libw32dll/DirectShow/outputpin.c Function: COutputPin_Destroy Description: Pointer "(This)->mempin" dereferenced before NULL check CVS patchset: 7951 CVS date: 2006/03/26 17:20:11 --- src/libw32dll/DirectShow/outputpin.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/libw32dll/DirectShow/outputpin.c b/src/libw32dll/DirectShow/outputpin.c index e6317a985..f971951f3 100644 --- a/src/libw32dll/DirectShow/outputpin.c +++ b/src/libw32dll/DirectShow/outputpin.c @@ -428,10 +428,11 @@ static void COutputPin_SetNewFormat(COutputPin* This, const AM_MEDIA_TYPE* amt) static void COutputPin_Destroy(COutputPin* This) { - if (This->mempin->vt) - free(This->mempin->vt); - if (This->mempin) + if (This->mempin) { + if (This->mempin->vt) + free(This->mempin->vt); free(This->mempin); + } if (This->vt) free(This->vt); free(This); -- cgit v1.2.3