From a67da65ffd7d96748aa1605c3a03601df5ec8c55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20=27Flameeyes=27=20Petten=C3=B2?= Date: Thu, 13 Dec 2007 15:28:36 +0100 Subject: Remove the need for a result variable, simply return the value of the _parse_tag function. Solves one uninitialised variable use. --HG-- extra : transplant_source : %9A._%DD%84%60SPH%3E%DF%D3%C0%D8y%9E-%BB%F1%C9 --- src/demuxers/id3.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/demuxers/id3.c b/src/demuxers/id3.c index b5c07e419..4149c0512 100644 --- a/src/demuxers/id3.c +++ b/src/demuxers/id3.c @@ -854,27 +854,22 @@ int id3v2_parse_tag(input_plugin_t *input, uint32_t id3_signature) { _x_assert((id3_signature & ID3V2X_MASK) == ID3V2X_TAG); - int result = 0; - switch(id3_signature) { case ID3V22_TAG: xprintf(stream->xine, XINE_VERBOSITY_LOG, "ID3V2.2 tag\n"); - result = id3v22_parse_tag(input, stream, id3_signature); - break; + return id3v22_parse_tag(input, stream, id3_signature); case ID3V23_TAG: xprintf(stream->xine, XINE_VERBOSITY_LOG, "ID3V2.3 tag\n"); - result = id3v23_parse_tag(input, stream, id3_signature); - break; + return id3v23_parse_tag(input, stream, id3_signature); case ID3V24_TAG: xprintf(stream->xine, XINE_VERBOSITY_LOG, "ID3V2.4 tag\n"); - result = id3v24_parse_tag(input, stream, id3_signature); - break; + return id3v24_parse_tag(input, stream, id3_signature); default: xprintf(stream->xine, XINE_VERBOSITY_LOG, "Unknown ID3v2 signature: 0x%08x.\n", be2me_32(id3_signature)); } - - return result; + + return 0; } -- cgit v1.2.3