Bug #115
closedMakefile should not install files automatically
0%
Description
The Makefile should not install files. It's really annoying when packaging it as a RPM because it just installs stuff without the possibility of intervening. This is especially annoying with locale files because they get installed into a path that needs to be supplied within the %build section of the spec file. That makes rpmlint cry.
Ville, you should know what I'm talking about :)
It would be great if a install target could be added in the Makefile.
Files
Updated by SPAM over 15 years ago
- File dxr3-makefile.patch dxr3-makefile.patch added
- Status changed from New to Assigned
- Assignee set to SPAM
I agree. However this is a problem with all VDR plugins I know of, and is caused by VDR's Makefile just running "make all" for plugins compiled along with it, so breaking the "all" contract and requiring "make install" to install the plugin should really be done in all plugins IMO, doing it only in dxr3 would only cause confusion.
But how about the attached patch; it leaves "make all" and "make" alone so that they effectively do the same thing as before, but adds a possibility to do "make libvdr-dxr3.so i18n" in %build which doesn't cause any files to be "installed" anywhere? Then in %install you could use "make all" to install the plugin.
Updated by SPAM over 15 years ago
Hmm, obviously something similar would need to be done to the "i18n" target without breaking plain "make" and "make all", ideas?
Updated by etobi over 15 years ago
Just as a small note: You can do something like:
make all LOCALEDIR=./tmp/whateverThis is what we do in the Debian packages with vdr plugins. See:
Updated by SPAM over 15 years ago
Sure, we do similar things in Fedora rpm packages, but it is annoying nevertheless, and would be better if there was a clean separation between building and installing plugins.
http://cvs.fedoraproject.org/viewvc/devel/vdr-ttxtsubs/vdr-ttxtsubs.spec?revision=1.11&view=markup
Updated by etobi over 15 years ago
Sure, but then this needs to be done for ALL plugin, meaning that Klaus needs to be convinced first.
Updated by SPAM over 15 years ago
Yes, which is pretty much what I said in note 1 in this bug :)
Updated by austriancoder about 15 years ago
- Status changed from Assigned to Rejected