Feature #1913
closedAdd action "Create inactive timer"
0%
Description
Hi,
I am using searchtimers looking generally for specific actors, directors, etc. These searchtimers often create multiple timers, for example because of the various regional channels, differing only slightly in their schedule, because of the SD/HD channels,...
For various reasons, I can't simply only search one of the various incarnation of a channel, as there are things, that are better Recorded in SD and other in HD. Thus, I have many timers that I have to switch to the inactive state in order to not record multiple times the same show and to avoid timer conflicts.
In my use case, it would require quite less manual intervention, if I could create searchtimers that sets timers in an inactive state; this way, I only have to activate the timer for the channel of interest instead of deactivating it for the various incarnations of that channel.
In other words, could you enhance epgsearch the following way:
- Create an additional action for the searchtimers, named for example "Create inactive timer", that create timers for the matches of the searchtimers, but these timers are in an inactive state.
- Maybe, in that case, it might also be better to rename the current "Record" action of the searchtimers to "Create active timer".
Many thanks in advance for taking this enhancement into account.
Cheers
Files
Updated by Ludi about 10 years ago
I am the author of this RFE. If you have any questions, please don't hesitate to contact me.
Updated by winni about 10 years ago
- Status changed from New to Confirmed
Hi Ludi,
it seems a bit odd to create an inactive timer ;-) But I've understood why you need it.
Currently other hobbies are more important to me than VDR, so please bear with me if this will not be implemented soon. Anyway, feel free to provide a patch, if you decide to do it on your own.
cheers,
Christian
Updated by Ludi about 10 years ago
Hi,
Sorry for not replying sooner, but I have not been notified by email about your reply.
Thanks for taking the request into account. Unfortunately, I don't have the know how to provide the patch, but I will keep in mind that you might accept it, if somebody is going to provide one.
Cheers
Updated by lhanisch almost 10 years ago
Here's a first version of a patch to add such a feature. It also removes a memory leak on freeing the menuitems selection strings of "UseChannelSel".
Memory leak only:
diff --git a/menu_searchedit.c b/menu_searchedit.c
--- a/menu_searchedit.c
+++ b/menu_searchedit.c
@@ -441,9 +441,9 @@ cMenuEditSearchExt::~cMenuEditSearchExt()
free(SearchModes[i]);
for(i=0; i<=7; i++)
free(DaysOfWeek[i]);
- for(i=0; i<=2; i++)
+ for(i=0; i<=3; i++)
free(UseChannelSel[i]);
- for(i=0; i<=2; i++)
+ for(i=0; i<=5; i++)
free(SearchTimerModes[i]);
for(i=0; i<=3; i++)
free(BlacklistModes[i]);
If you don't add this feature the loop on SearchTimerModes must only go to 4.
Updated by lhanisch almost 10 years ago
Forgot to mention: live has to be modified to offer this new switch.
Updated by Ludi almost 10 years ago
Many thanks for the patch with the new feature. I have copied the changes to the source without the noise of the po files (which I think that will be auto-generated) by using quilt. Hoping that I did not make any error copying the changes to the source. Moreover, I am adding the patch created by quilt to this message.
Updated by flobee over 9 years ago
yes, thats what i want to request also! :-) some timers i want to have created automatically but inactive to decide then if i want them or not or to avoid confilcts because dvb-c and dvb-t dongels needs to be checked bi hand :-(
Kind regards flobee
Updated by fnu over 7 years ago
- Due date set to 05/02/2017
- Status changed from Confirmed to Closed
As far as I can see, those patches/functionality is now commited to master branch for VDR 2.3.x.