Project

General

Profile

Actions

Bug #240

closed

replayed streams don't show subs.

Added by Anonymous almost 15 years ago. Updated almost 15 years ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Start date:
02/08/2010
Due date:
% Done:

100%

Estimated time:

Description

Attempting to replay a recording that has teletext subs fills the logs with:
ttxtsubs: ERROR: not a cTtxtSubsPlayer!

It seems that mDispl is always NULL in this case. With some minimal examination of the code it seems that mDispl is never assigned and mReplay is always false.

Actions #1

Updated by mjl almost 15 years ago

Anonymous wrote:

Attempting to replay a recording that has teletext subs fills the logs with:
ttxtsubs: ERROR: not a cTtxtSubsPlayer!

It seems that mDispl is always NULL in this case. With some minimal examination of the code it seems that mDispl is never assigned and mReplay is always false.

I should have stated that I'm using 1.7.11 with up-to-the-second ttxtsubs git. I've also tried 1.7.12 with vdr-1.7.12-ttxtsubs-tpid-v2.patch and had the same result.

Actions #2

Updated by etobi almost 15 years ago

Do you have a manual page number configured for the channel of this recording?
Can you provide a 5 minutes snippet of the recording?

Actions #3

Updated by mjl almost 15 years ago

I'll happily provide 5minutes of recording, there'll be a short delay on that while I clear some space on a server somewhere.

I haven't set a manual page number, how do I do that? I can't find it in the docs anywhere.

Actions #4

Updated by etobi almost 15 years ago

Great!

The manual page number can be configured, if you change the main menu entry in the plugin settings to "Page Selection". This is required especially for German broadcasters, which fail to correctly implement the DVB standards.

Actions #5

Updated by mjl almost 15 years ago

a 100mb sample is available @ http://mjlmedia.com/vdr/00001.ts ... I'll delete it after 24hours, unless you need longer.

Thanks for the heads-up on how to setup manual page selection. I possibly related issue I've found is that often subs won't display even when setting the page manually. If I use osdteletext and select the subtitle page it works though, so I know there are subs available.

If there's anything I can do to help, please let me know.

Actions #6

Updated by etobi almost 15 years ago

Thx, I've downloaded it. Can you please provide the info-File well?

Actions #7

Updated by mjl almost 15 years ago

Actions #8

Updated by mjl almost 15 years ago

the index file is also in the same directory, if you want it.

Actions #9

Updated by etobi almost 15 years ago

Thanks! Now I have everything I need. I'll try to figure out, what's going wrong here.

Actions #10

Updated by etobi almost 15 years ago

  • Assignee set to etobi
  • Target version set to Version 0.2.0
  • % Done changed from 0 to 50

Ok. I think I have a solution now. It requires modifications to the VDR-patch. Your recording works fine with it. I'll commit it within the next two days.

Actions #11

Updated by mjl almost 15 years ago

etobi wrote:

Ok. I think I have a solution now. It requires modifications to the VDR-patch. Your recording works fine with it. I'll commit it within the next two days.

Great! thanks for your efforts. What was the problem/solution?

Actions #12

Updated by etobi almost 15 years ago

The old ttxtsubs modified the teletext info page and inserted the subtitle page numbers there, which then were used for playback.
With the change to 1.7.x/TS, this has changed. The page numbers must now be parsed from the PMT and must be explicitly passed to the plugin.

Actions #13

Updated by Anonymous almost 15 years ago

  • Status changed from New to Closed
  • % Done changed from 50 to 100
Actions #14

Updated by mjl almost 15 years ago

Current git works perfectly for recordings, however now live tv containing subs spams the logs with:

Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
... continues ad-nauseum ...

Actions #15

Updated by mjl almost 15 years ago

mjl wrote:

Current git works perfectly for recordings, however now live tv containing subs spams the logs with:

Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
Feb 14 13:28:15 mike vdr: [10088] ttxtsubs: ERROR: not a cTtxtSubsPlayer!
... continues ad-nauseum ...

Just to add, live subs do actually work, in spite of the log-spamming.

Actions #16

Updated by mjl almost 15 years ago

As a further update, it seems that the logspamming occurs only after one of the following:

- after 2nd channel change. (1st switch to a channel with teletext has no problem)
- after stopping playback of a recording.

after either of the above, logspamming is continuous.

Actions #17

Updated by etobi almost 15 years ago

Please try again with the current Git version.

Actions #18

Updated by mjl almost 15 years ago

etobi wrote:

Please try again with the current Git version.

Hehe, yeah that works :) consider bug 240 fully resolved.

Actions

Also available in: Atom PDF