summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@infradead.org>2008-03-23 22:43:22 +0000
committerMauro Carvalho Chehab <mchehab@infradead.org>2008-03-23 22:43:22 +0000
commit682ce8fad34b8959b55ecd597934732e68453c6d (patch)
tree182225298ae7bedc886b58c6d4958a423312449b
parent3c3c7a09f67b2a233bb32d98b3df6f483d084938 (diff)
downloadmediapointer-dvb-s2-682ce8fad34b8959b55ecd597934732e68453c6d.tar.gz
mediapointer-dvb-s2-682ce8fad34b8959b55ecd597934732e68453c6d.tar.bz2
cx88: Enable chroma AGC by default for all non-SECAM modes
From: Frej Drejhammar <frej.drejhammar@gmail.com> An enabled chroma AGC will not degrade picture quality if enabled on a color PAL or NTSC signal with nominal signal levels. It will give a significant color reproduction improvement if the chroma signals diverge from nominal levels. Therefore enable chroma AGC by default for PAL and NTSC standards. Signed-off-by: "Frej Drejhammar <frej.drejhammar@gmail.com>" Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r--linux/drivers/media/video/cx88/cx88-core.c9
-rw-r--r--linux/drivers/media/video/cx88/cx88-video.c2
2 files changed, 5 insertions, 6 deletions
diff --git a/linux/drivers/media/video/cx88/cx88-core.c b/linux/drivers/media/video/cx88/cx88-core.c
index 63a104789..a580d3706 100644
--- a/linux/drivers/media/video/cx88/cx88-core.c
+++ b/linux/drivers/media/video/cx88/cx88-core.c
@@ -958,11 +958,10 @@ int cx88_set_tvnorm(struct cx88_core *core, v4l2_std_id norm)
dprintk(1,"set_tvnorm: MO_INPUT_FORMAT 0x%08x [old=0x%08x]\n",
cxiformat, cx_read(MO_INPUT_FORMAT) & 0x0f);
- /* Chroma AGC must be disabled if SECAM is used */
- if (norm & V4L2_STD_SECAM)
- cx_andor(MO_INPUT_FORMAT, 0x40f, cxiformat);
- else
- cx_andor(MO_INPUT_FORMAT, 0xf, cxiformat);
+ /* Chroma AGC must be disabled if SECAM is used, we enable it
+ by default on PAL and NTSC */
+ cx_andor(MO_INPUT_FORMAT, 0x40f,
+ norm & V4L2_STD_SECAM ? cxiformat : cxiformat | 0x400);
#if 1
// FIXME: as-is from DScaler
diff --git a/linux/drivers/media/video/cx88/cx88-video.c b/linux/drivers/media/video/cx88/cx88-video.c
index 9974d1aed..8b7e23f2b 100644
--- a/linux/drivers/media/video/cx88/cx88-video.c
+++ b/linux/drivers/media/video/cx88/cx88-video.c
@@ -249,7 +249,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
.name = "Chroma AGC",
.minimum = 0,
.maximum = 1,
- .default_value = 0x0,
+ .default_value = 0x1,
.type = V4L2_CTRL_TYPE_BOOLEAN,
},
.reg = MO_INPUT_FORMAT,