diff options
| author | Geert Uytterhoeven <geert@linux-m68k.org> | 2008-08-27 22:20:15 +0200 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2008-08-27 22:20:15 +0200 |
| commit | a9bf92eb33a4ad79b8093c90379fb9d7519f1c88 (patch) | |
| tree | f11795d901711d1b1b61e440fd7b80772564f148 | |
| parent | 5232a98b6146a74010539ba94a8e8e6f8a6fa48d (diff) | |
| download | mediapointer-dvb-s2-a9bf92eb33a4ad79b8093c90379fb9d7519f1c88.tar.gz mediapointer-dvb-s2-a9bf92eb33a4ad79b8093c90379fb9d7519f1c88.tar.bz2 | |
VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig)
Hi Andrew,
On Thu, 14 Aug 2008, Andrew Morton wrote:
> ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined!
M68k allmodconfig still selects Sun-3, which sets NO_DMA.
I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r,
s390, and PCI-less SPARC)?
Below is a patch.
Shouldn't it also (or instead) depend on SUPERH or some SuperH platform?
Or is this not done to have more compile-coverage?
Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342):
sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced
VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the
dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG.
Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Magnus Damm <damm@igel.co.jp>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
drivers/media/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| -rw-r--r-- | linux/drivers/media/video/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/linux/drivers/media/video/Kconfig b/linux/drivers/media/video/Kconfig index 7b2925808..7f7482bff 100644 --- a/linux/drivers/media/video/Kconfig +++ b/linux/drivers/media/video/Kconfig @@ -822,7 +822,7 @@ config VIDEO_PXA27x config VIDEO_SH_MOBILE_CEU tristate "SuperH Mobile CEU Interface driver" - depends on VIDEO_DEV && SOC_CAMERA + depends on VIDEO_DEV && SOC_CAMERA && HAS_DMA select VIDEOBUF_DMA_CONTIG ---help--- This is a v4l2 driver for the SuperH Mobile CEU Interface |