diff options
| author | Michael Krufky <mkrufky@linuxtv.org> | 2008-09-06 13:56:58 -0400 |
|---|---|---|
| committer | Michael Krufky <mkrufky@linuxtv.org> | 2008-09-06 13:56:58 -0400 |
| commit | 507449b0440221c834914389d808f4728dcd2702 (patch) | |
| tree | f2d7d16845daed6ebc5fa25d1f5ea66526d7aa20 /linux/drivers/media/common/tuners/xc5000.h | |
| parent | 8cab49c4acd229cb28d9add11a80eed55859ba2d (diff) | |
| download | mediapointer-dvb-s2-507449b0440221c834914389d808f4728dcd2702.tar.gz mediapointer-dvb-s2-507449b0440221c834914389d808f4728dcd2702.tar.bz2 | |
xc5000: dont pass devptr in xc5000_attach()
From: Michael Krufky <mkrufky@linuxtv.org>
Dont pass devptr in xc5000_attach, dont store it in xc5000_priv.
This pointer is passed into the tuner_callback function, which always
expects a pointer to fe->dvb->priv or i2c_adapter->algo_data.
This prevents future possible bugs in new drivers, such as using a "devptr"
other that the standard fe->dvb->priv in a DVB driver.
Priority: normal
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Diffstat (limited to 'linux/drivers/media/common/tuners/xc5000.h')
| -rw-r--r-- | linux/drivers/media/common/tuners/xc5000.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/linux/drivers/media/common/tuners/xc5000.h b/linux/drivers/media/common/tuners/xc5000.h index 5389f7409..fa0321cfd 100644 --- a/linux/drivers/media/common/tuners/xc5000.h +++ b/linux/drivers/media/common/tuners/xc5000.h @@ -49,13 +49,11 @@ struct xc5000_config { (defined(CONFIG_MEDIA_TUNER_XC5000_MODULE) && defined(MODULE)) extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, - struct xc5000_config *cfg, - void *devptr); + struct xc5000_config *cfg); #else static inline struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, - struct xc5000_config *cfg, - void *devptr) + struct xc5000_config *cfg) { printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); return NULL; |