diff options
author | Mauro Carvalho Chehab <devnull@localhost> | 2005-12-08 15:50:06 +0000 |
---|---|---|
committer | Mauro Carvalho Chehab <devnull@localhost> | 2005-12-08 15:50:06 +0000 |
commit | 90019d346efd7c172caf5de5e4452a14cdc8cc3c (patch) | |
tree | d09f52042485bcccad34171aa3b15b24bc299deb /linux/drivers/media/common | |
parent | 9f7c5513964f4aa7c2d7bcd79d56f3e5002d4a58 (diff) | |
download | mediapointer-dvb-s2-90019d346efd7c172caf5de5e4452a14cdc8cc3c.tar.gz mediapointer-dvb-s2-90019d346efd7c172caf5de5e4452a14cdc8cc3c.tar.bz2 |
syncronizes some changes between v4l and dvb
- Updated firmware names
- kfree (NULL) is valid.
- assert_spin_locked() is the new way
- small fixes to make in sync with kernel
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Diffstat (limited to 'linux/drivers/media/common')
-rw-r--r-- | linux/drivers/media/common/saa7146_core.c | 6 | ||||
-rw-r--r-- | linux/drivers/media/common/saa7146_fops.c | 12 | ||||
-rw-r--r-- | linux/drivers/media/common/saa7146_video.c | 11 |
3 files changed, 7 insertions, 22 deletions
diff --git a/linux/drivers/media/common/saa7146_core.c b/linux/drivers/media/common/saa7146_core.c index c6b7f3763..c6889d003 100644 --- a/linux/drivers/media/common/saa7146_core.c +++ b/linux/drivers/media/common/saa7146_core.c @@ -168,10 +168,8 @@ void saa7146_pgtable_free(struct pci_dev *pci, struct saa7146_pgtable *pt) return; pci_free_consistent(pci, pt->size, pt->cpu, pt->dma); pt->cpu = NULL; - if (NULL != pt->slist) { - kfree(pt->slist); - pt->slist = NULL; - } + kfree(pt->slist); + pt->slist = NULL; } int saa7146_pgtable_alloc(struct pci_dev *pci, struct saa7146_pgtable *pt) diff --git a/linux/drivers/media/common/saa7146_fops.c b/linux/drivers/media/common/saa7146_fops.c index 57c661c8e..e1a9f8471 100644 --- a/linux/drivers/media/common/saa7146_fops.c +++ b/linux/drivers/media/common/saa7146_fops.c @@ -73,9 +73,7 @@ int saa7146_buffer_queue(struct saa7146_dev *dev, struct saa7146_dmaqueue *q, struct saa7146_buf *buf) { -#ifdef DEBUG_SPINLOCKS - BUG_ON(!spin_is_locked(&dev->slock)); -#endif + assert_spin_locked(&dev->slock); DEB_EE(("dev:%p, dmaq:%p, buf:%p\n", dev, q, buf)); BUG_ON(!q); @@ -96,9 +94,7 @@ void saa7146_buffer_finish(struct saa7146_dev *dev, struct saa7146_dmaqueue *q, int state) { -#ifdef DEBUG_SPINLOCKS - BUG_ON(!spin_is_locked(&dev->slock)); -#endif + assert_spin_locked(&dev->slock); DEB_EE(("dev:%p, dmaq:%p, state:%d\n", dev, q, state)); DEB_EE(("q->curr:%p\n",q->curr)); @@ -126,9 +122,7 @@ void saa7146_buffer_next(struct saa7146_dev *dev, DEB_INT(("dev:%p, dmaq:%p, vbi:%d\n", dev, q, vbi)); -#ifdef DEBUG_SPINLOCKS - BUG_ON(!spin_is_locked(&dev->slock)); -#endif + assert_spin_locked(&dev->slock); if (!list_empty(&q->queue)) { /* activate next one from queue */ buf = list_entry(q->queue.next,struct saa7146_buf,vb.queue); diff --git a/linux/drivers/media/common/saa7146_video.c b/linux/drivers/media/common/saa7146_video.c index 46d571423..68d777bdf 100644 --- a/linux/drivers/media/common/saa7146_video.c +++ b/linux/drivers/media/common/saa7146_video.c @@ -1007,10 +1007,6 @@ int saa7146_video_do_ioctl(struct inode *inode, struct file *file, unsigned int return get_control(fh,arg); } case VIDIOC_S_CTRL: -/* FIXME: remove when videodev2.h update is in kernel */ -#ifdef VIDIOC_S_CTRL_OLD - case VIDIOC_S_CTRL_OLD: -#endif { DEB_EE(("VIDIOC_S_CTRL\n")); err = set_control(fh,arg); @@ -1119,10 +1115,6 @@ int saa7146_video_do_ioctl(struct inode *inode, struct file *file, unsigned int return 0; } case VIDIOC_OVERLAY: -/* FIXME: remove when videodev2.h update is in kernel */ -#ifdef VIDIOC_OVERLAY_OLD - case VIDIOC_OVERLAY_OLD: -#endif { int on = *(int *)arg; int err = 0; @@ -1248,7 +1240,8 @@ static int buffer_activate (struct saa7146_dev *dev, return 0; } -static int buffer_prepare(struct videobuf_queue *q, struct videobuf_buffer *vb,enum v4l2_field field) +static int buffer_prepare(struct videobuf_queue *q, + struct videobuf_buffer *vb, enum v4l2_field field) { struct file *file = q->priv_data; struct saa7146_fh *fh = file->private_data; |