diff options
| author | Marcel Siegert <mws@linuxtv.org> | 2007-02-13 13:46:55 +0100 |
|---|---|---|
| committer | Marcel Siegert <mws@linuxtv.org> | 2007-02-13 13:46:55 +0100 |
| commit | 9178eac040383ea6cd91d6a58aab3fc598aecf77 (patch) | |
| tree | b3e67afd907640f55d104e7d26a7b8ede9211f7e /linux/drivers/media/dvb/dvb-core | |
| parent | 0173038bafb808d93f88b3f0b043696b04cc2ded (diff) | |
| download | mediapointer-dvb-s2-9178eac040383ea6cd91d6a58aab3fc598aecf77.tar.gz mediapointer-dvb-s2-9178eac040383ea6cd91d6a58aab3fc598aecf77.tar.bz2 | |
dvbdev: fix illegal re-usage of fileoperations struct
From: Marcel Siegert <mws@linuxtv.org>
Arjan van de Ven <arjan@infradead.org> reported an illegal re-usage of the fileoperations struct
if more than one dvb device(e.g. frontend) is present. this patch fixes this issue.
it allocates a new fileoperations struct each time a device is registered and copies the default
template fileops.
Signed-off-by: Marcel Siegert <mws@linuxtv.org>
Diffstat (limited to 'linux/drivers/media/dvb/dvb-core')
| -rw-r--r-- | linux/drivers/media/dvb/dvb-core/dvbdev.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/linux/drivers/media/dvb/dvb-core/dvbdev.c b/linux/drivers/media/dvb/dvb-core/dvbdev.c index 498b1e1be..4035f8efa 100644 --- a/linux/drivers/media/dvb/dvb-core/dvbdev.c +++ b/linux/drivers/media/dvb/dvb-core/dvbdev.c @@ -211,12 +211,14 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, const struct dvb_device *template, void *priv, int type) { struct dvb_device *dvbdev; + struct file_operations *dvbdevfops; + int id; if (mutex_lock_interruptible(&dvbdev_register_lock)) return -ERESTARTSYS; - if ((id = dvbdev_get_free_id (adap, type)) < 0) { + if ((id = dvbdev_get_free_id (adap, type)) < 0){ mutex_unlock(&dvbdev_register_lock); *pdvbdev = NULL; printk ("%s: could get find free device id...\n", __FUNCTION__); @@ -225,7 +227,15 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, *pdvbdev = dvbdev = kmalloc(sizeof(struct dvb_device), GFP_KERNEL); - if (!dvbdev) { + if (!dvbdev){ + mutex_unlock(&dvbdev_register_lock); + return -ENOMEM; + } + + dvbdevfops = kzalloc(sizeof(struct file_operations), GFP_KERNEL); + + if (!dvbdevfops){ + kfree (dvbdev); mutex_unlock(&dvbdev_register_lock); return -ENOMEM; } @@ -235,7 +245,9 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, dvbdev->id = id; dvbdev->adapter = adap; dvbdev->priv = priv; + dvbdev->fops = dvbdevfops; + memcpy(dvbdev->fops, template->fops, sizeof(struct file_operations)); dvbdev->fops->owner = adap->module; list_add_tail (&dvbdev->list_head, &adap->device_list); @@ -263,6 +275,7 @@ void dvb_unregister_device(struct dvb_device *dvbdev) dvbdev->type, dvbdev->id))); list_del (&dvbdev->list_head); + kfree (dvbdev->fops); kfree (dvbdev); } EXPORT_SYMBOL(dvb_unregister_device); |