Here comes a huge cleanup patch in order to get the sources into

"kernel shape":

I mainly changed all "typedef struct foo_s {...} foo_t"
to "struct foo {}". Please don't start a policy war, I know the pros
cons of typedefs and structures.

We should, however, stick to the coding rules of the kernel: typedefed
structs are only used for opaque data types, where the internal
representation is irrelevant and we have get()/set() functions for
accessing them (ie. spinlock_t)

2 files changed, 35 insertions, 35 deletions

diff --git a/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c b/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c
index 2b845e216..1e9d8ddc6 100644
--- a/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c
+++ b/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c
@@ -33,7 +33,7 @@ static int debug = 0;
 #define dprintk	if (debug) printk
 
 static int
-ttusb_dec_send_command(ttusb_dec_t * dec, const u8 command, int param_length,
+ttusb_dec_send_command(struct ttusb_dec * dec, const u8 command, int param_length,
 		       const u8 params[], int *result_length, u8 cmd_result[])
 {
 
@@ -127,7 +127,7 @@ ttusb_dec_av_pes2ts_cb(void *priv, unsigned char *data)
 }
 
 static void
-ttusb_dec_set_pids(ttusb_dec_t * dec)
+ttusb_dec_set_pids(struct ttusb_dec * dec)
 {
 
 	u8 b[] =
@@ -180,7 +180,7 @@ ttusb_dec_i2c_master_xfer(struct dvb_i2c_bus *i2c, const struct i2c_msg msgs[],
 }
 
 static void
-ttusb_dec_process_av_pes(ttusb_dec_t * dec, u8 * av_pes, int length)
+ttusb_dec_process_av_pes(struct ttusb_dec * dec, u8 * av_pes, int length)
 {
 
 	int i;
@@ -327,7 +327,7 @@ ttusb_dec_process_av_pes(ttusb_dec_t * dec, u8 * av_pes, int length)
 }
 
 static void
-ttusb_dec_process_urb_frame(ttusb_dec_t * dec, u8 * b, int length)
+ttusb_dec_process_urb_frame(struct ttusb_dec * dec, u8 * b, int length)
 {
 
 	while (length) {
@@ -441,7 +441,7 @@ ttusb_dec_process_urb(struct urb *urb, struct pt_regs *ptregs)
 #endif
 {
 
-	ttusb_dec_t *dec = urb->context;
+	struct ttusb_dec *dec = urb->context;
 
 	if (!urb->status) {
 
@@ -477,7 +477,7 @@ ttusb_dec_process_urb(struct urb *urb, struct pt_regs *ptregs)
 }
 
 static void
-ttusb_dec_setup_urbs(ttusb_dec_t * dec)
+ttusb_dec_setup_urbs(struct ttusb_dec * dec)
 {
 
 	int i, j, buffer_offset = 0;
@@ -516,7 +516,7 @@ ttusb_dec_setup_urbs(ttusb_dec_t * dec)
 }
 
 static void
-ttusb_dec_stop_iso_xfer(ttusb_dec_t * dec)
+ttusb_dec_stop_iso_xfer(struct ttusb_dec * dec)
 {
 
 	int i;
@@ -544,7 +544,7 @@ ttusb_dec_stop_iso_xfer(ttusb_dec_t * dec)
 }
 
 static int
-ttusb_dec_start_iso_xfer(ttusb_dec_t *dec)
+ttusb_dec_start_iso_xfer(struct ttusb_dec *dec)
 {
 
 	int i, result;
@@ -628,7 +628,7 @@ ttusb_dec_start_feed(struct dvb_demux_feed *dvbdmxfeed)
 {
 
 	struct dvb_demux *dvbdmx = dvbdmxfeed->demux;
-	ttusb_dec_t *dec = dvbdmx->priv;
+	struct ttusb_dec *dec = dvbdmx->priv;
 
 	dprintk("%s\n", __FUNCTION__);
 
@@ -712,7 +712,7 @@ static int
 ttusb_dec_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
 {
 
-	ttusb_dec_t *dec = dvbdmxfeed->demux->priv;
+	struct ttusb_dec *dec = dvbdmxfeed->demux->priv;
 
 	dprintk("%s\n", __FUNCTION__);
 
@@ -723,7 +723,7 @@ ttusb_dec_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
 }
 
 static void
-ttusb_dec_free_iso_urbs(ttusb_dec_t * dec)
+ttusb_dec_free_iso_urbs(struct ttusb_dec * dec)
 {
 
 	int i;
@@ -742,7 +742,7 @@ ttusb_dec_free_iso_urbs(ttusb_dec_t * dec)
 }
 
 static int
-ttusb_dec_alloc_iso_urbs(ttusb_dec_t * dec)
+ttusb_dec_alloc_iso_urbs(struct ttusb_dec * dec)
 {
 
 	int i;
@@ -789,7 +789,7 @@ ttusb_dec_alloc_iso_urbs(ttusb_dec_t * dec)
 }
 
 static void
-ttusb_dec_init_v_pes(ttusb_dec_t * dec)
+ttusb_dec_init_v_pes(struct ttusb_dec * dec)
 {
 
 	dprintk("%s\n", __FUNCTION__);
@@ -802,7 +802,7 @@ ttusb_dec_init_v_pes(ttusb_dec_t * dec)
 }
 
 static void
-ttusb_dec_init_usb(ttusb_dec_t * dec)
+ttusb_dec_init_usb(struct ttusb_dec * dec)
 {
 
 	dprintk("%s\n", __FUNCTION__);
@@ -821,7 +821,7 @@ ttusb_dec_init_usb(ttusb_dec_t * dec)
 #include "dsp_dec2000.h"
 
 static int
-ttusb_dec_boot_dsp(ttusb_dec_t * dec)
+ttusb_dec_boot_dsp(struct ttusb_dec * dec)
 {
 
 	int i, j, actual_len, result, size, trans_count;
@@ -882,7 +882,7 @@ ttusb_dec_boot_dsp(ttusb_dec_t * dec)
 }
 
 static void
-ttusb_dec_init_stb(ttusb_dec_t * dec)
+ttusb_dec_init_stb(struct ttusb_dec * dec)
 {
 
 	u8 c[COMMAND_PACKET_SIZE];
@@ -901,7 +901,7 @@ ttusb_dec_init_stb(ttusb_dec_t * dec)
 }
 
 static int
-ttusb_dec_init_dvb(ttusb_dec_t * dec)
+ttusb_dec_init_dvb(struct ttusb_dec * dec)
 {
 
 	int result;
@@ -1017,7 +1017,7 @@ ttusb_dec_init_dvb(ttusb_dec_t * dec)
 }
 
 static void
-ttusb_dec_exit_dvb(ttusb_dec_t * dec)
+ttusb_dec_exit_dvb(struct ttusb_dec * dec)
 {
 
 	dprintk("%s\n", __FUNCTION__);
@@ -1033,7 +1033,7 @@ ttusb_dec_exit_dvb(ttusb_dec_t * dec)
 }
 
 static void
-ttusb_dec_exit_usb(ttusb_dec_t * dec)
+ttusb_dec_exit_usb(struct ttusb_dec * dec)
 {
 
 	int i;
@@ -1053,21 +1053,21 @@ ttusb_dec_probe(struct usb_device *udev, unsigned int ifnum,
 		const struct usb_device_id *id)
 {
 
-	ttusb_dec_t *dec;
+	struct ttusb_dec *dec;
 
 	dprintk("%s\n", __FUNCTION__);
 
 	if (ifnum != 0)
 		return NULL;
 
-	if (!(dec = kmalloc(sizeof (ttusb_dec_t), GFP_KERNEL))) {
+	if (!(dec = kmalloc(sizeof (struct ttusb_dec), GFP_KERNEL))) {
 
 		printk("%s: couldn't allocate memory.\n", __FUNCTION__);
 		return NULL;
 
 	}
 
-	memset(dec, 0, sizeof (ttusb_dec_t));
+	memset(dec, 0, sizeof (struct ttusb_dec));
 
 	dec->udev = udev;
 
@@ -1088,20 +1088,20 @@ ttusb_dec_probe(struct usb_interface *intf, const struct usb_device_id *id)
 {
 
 	struct usb_device *udev;
-	ttusb_dec_t *dec;
+	struct ttusb_dec *dec;
 
 	dprintk("%s\n", __FUNCTION__);
 
 	udev = interface_to_usbdev(intf);
 
-	if (!(dec = kmalloc(sizeof (ttusb_dec_t), GFP_KERNEL))) {
+	if (!(dec = kmalloc(sizeof (struct ttusb_dec), GFP_KERNEL))) {
 
 		printk("%s: couldn't allocate memory.\n", __FUNCTION__);
 		return -ENOMEM;
 
 	}
 
-	memset(dec, 0, sizeof (ttusb_dec_t));
+	memset(dec, 0, sizeof (struct ttusb_dec));
 
 	dec->udev = udev;
 
@@ -1125,13 +1125,13 @@ static void
 ttusb_dec_disconnect(struct usb_device *udev, void *data)
 {
 
-	ttusb_dec_t *dec = data;
+	struct ttusb_dec *dec = data;
 #else
 static void
 ttusb_dec_disconnect(struct usb_interface *intf)
 {
 
-	ttusb_dec_t *dec = usb_get_intfdata(intf);
+	struct ttusb_dec *dec = usb_get_intfdata(intf);
 
 	usb_set_intfdata(intf, NULL);
 #endif
diff --git a/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.h b/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.h
index b0dd8199c..e0b9097be 100644
--- a/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.h
+++ b/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.h
@@ -44,15 +44,15 @@
 
 #define	MAX_AV_PES_LENGTH	6144
 
-typedef struct ttusb_dec_s {
+struct ttusb_dec {
 
 	/* DVB bits */
 	struct dvb_adapter	*adapter;
-	dmxdev_t		dmxdev;
+	struct dmxdev		dmxdev;
 	struct dvb_demux	demux;
-	dmx_frontend_t		frontend;
+	struct dmx_frontend	frontend;
 	struct dvb_i2c_bus	*i2c_bus;
-	dvb_net_t		dvb_net;
+	struct dvb_net		dvb_net;
 
 	u16			pid[DMX_PES_OTHER];
 
@@ -76,14 +76,14 @@ typedef struct ttusb_dec_s {
 	int			av_pes_length;
 	int			av_pes_payload_length;
 
-	dvb_filter_pes2ts_t	a_pes2ts;
-	dvb_filter_pes2ts_t	v_pes2ts;
-	struct semaphore	pes2ts_sem;
+	struct dvb_filter_pes2ts	a_pes2ts;
+	struct dvb_filter_pes2ts	v_pes2ts;
+	struct semaphore		pes2ts_sem;
 
 	u8			v_pes[16 + MAX_AV_PES_LENGTH];
 	int			v_pes_length;
 	int			v_pes_postbytes;
 
-} ttusb_dec_t;
+};
 
 #endif