summaryrefslogtreecommitdiff
path: root/linux/drivers/media/video/bw-qcam.c
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@redhat.com>2009-02-16 15:27:44 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-02-16 15:27:44 -0300
commit03bcc8695fb4334e4e30d03a9dc0867361615c1a (patch)
tree7f64938164c59ffd2988a87fc5c1a167a3d4e4fd /linux/drivers/media/video/bw-qcam.c
parentc02991ae9384f6940ac34f853f5191b7bcf1f453 (diff)
downloadmediapointer-dvb-s2-03bcc8695fb4334e4e30d03a9dc0867361615c1a.tar.gz
mediapointer-dvb-s2-03bcc8695fb4334e4e30d03a9dc0867361615c1a.tar.bz2
Revert changeset aa3e5cc1d833
From: Mauro Carvalho Chehab <mchehab@redhat.com> On Mon, 02 Feb 2009, Hartmut wrote: This change set is wrong. The affected functions cannot be called from an interrupt context, because they may process large buffers. In this case, interrupts are disabled for a long time. Functions, like dvb_dmx_swfilter_packets(), could be called only from a tasklet. This change set does hide some strong design bugs in dm1105.c and au0828-dvb.c. Please revert this change set and do fix the bugs in dm1105.c and au0828-dvb.c (and other files). On Sun, 15 Feb 2009, Oliver Endriss wrote: This changeset _must_ be reverted! It breaks all kernels since 2.6.27 for applications which use DVB and require a low interrupt latency. It is a very bad idea to call the demuxer to process data buffers with interrupts disabled! On Mon, 16 Feb 2009, Trent Piepho wrote: I agree, this is bad. The demuxer is far too much work to be done with IRQs off. IMHO, even doing it under a spin-lock is excessive. It should be a mutex. Drivers should use a work-queue to feed the demuxer. Thank you for testing this changeset and discovering the issues on it. Priority: high CC: Trent Piepho <xyzzy@speakeasy.org> CC: Hartmut <e9hack@googlemail.com> CC: Oliver Endriss <o.endriss@gmx.de> CC: Andreas Oberritter <obi@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'linux/drivers/media/video/bw-qcam.c')
0 files changed, 0 insertions, 0 deletions