diff options
| author | Andy Walls <awalls@radix.net> | 2009-01-17 11:37:36 -0500 |
|---|---|---|
| committer | Andy Walls <awalls@radix.net> | 2009-01-17 11:37:36 -0500 |
| commit | d4a74e2c49a3023d582f564d64a832c7321a1dfa (patch) | |
| tree | 43709785b2baee1211c8f9946c031f4b53be9576 /linux/drivers/media/video/cx18 | |
| parent | c6138eadff2f01fd6d20a1f9a39b6ba4cbeff85b (diff) | |
| download | mediapointer-dvb-s2-d4a74e2c49a3023d582f564d64a832c7321a1dfa.tar.gz mediapointer-dvb-s2-d4a74e2c49a3023d582f564d64a832c7321a1dfa.tar.bz2 | |
cx18: Call request_module() with proper argument types.
From: Andy Walls <awalls@radix.net>
request_module() needs to be called with a string literal for a
format string or with 1 or more variable arguments to avoid
compiler warnings and possible exploits, if someone could cause
us to get a format string with a '%' code in the format string
when we make the call.
Reported-by: Brandon Jenkins <bcjenkins@tvwhere.com>
Priority: normal
Signed-off-by: Andy Walls <awalls@radix.net>
Diffstat (limited to 'linux/drivers/media/video/cx18')
| -rw-r--r-- | linux/drivers/media/video/cx18/cx18-driver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/linux/drivers/media/video/cx18/cx18-driver.c b/linux/drivers/media/video/cx18/cx18-driver.c index ea23d34dc..60ffc8ae2 100644 --- a/linux/drivers/media/video/cx18/cx18-driver.c +++ b/linux/drivers/media/video/cx18/cx18-driver.c @@ -733,7 +733,7 @@ static u32 cx18_request_module(struct cx18 *cx, u32 hw, { if ((hw & id) == 0) return hw; - if (request_module(name) != 0) { + if (request_module("%s", name) != 0) { CX18_ERR("Failed to load module %s\n", name); return hw & ~id; } |