diff options
| author | Hans Verkuil <hverkuil@xs4all.nl> | 2007-02-27 20:06:09 +0100 |
|---|---|---|
| committer | Hans Verkuil <hverkuil@xs4all.nl> | 2007-02-27 20:06:09 +0100 |
| commit | ef5e52021856647afdbf2f88b5564cb22250290b (patch) | |
| tree | 066a0a5ba8a5e5051ce91868dc830c39ceab7624 /linux/drivers/media/video/cx25840 | |
| parent | 89332c1ec9b859922645e86f2fef316ebdc3ff28 (diff) | |
| download | mediapointer-dvb-s2-ef5e52021856647afdbf2f88b5564cb22250290b.tar.gz mediapointer-dvb-s2-ef5e52021856647afdbf2f88b5564cb22250290b.tar.bz2 | |
Improve VIDIOC_G_CHIP_IDENT (better diagnostics)
From: Hans Verkuil <hverkuil@xs4all.nl>
Simplify the VIDIOC_G_CHIP_IDENT implementation by adding a single
common function. The ident can now also return NONE: not found, UNKNOWN:
found, but we don't know what chip it is, and AMBIGUOUS: multiple
chips were matched so the match values were too general.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Diffstat (limited to 'linux/drivers/media/video/cx25840')
| -rw-r--r-- | linux/drivers/media/video/cx25840/cx25840-core.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/linux/drivers/media/video/cx25840/cx25840-core.c b/linux/drivers/media/video/cx25840/cx25840-core.c index d5a0789bc..c401c1ee7 100644 --- a/linux/drivers/media/video/cx25840/cx25840-core.c +++ b/linux/drivers/media/video/cx25840/cx25840-core.c @@ -840,15 +840,7 @@ static int cx25840_command(struct i2c_client *client, unsigned int cmd, break; case VIDIOC_G_CHIP_IDENT: - { - struct v4l2_chip_ident *chip = arg; - - if (!v4l2_chip_match_i2c_client(client, chip->match_type, chip->match_chip)) - return -EINVAL; - chip->ident = state->id; - chip->revision = state->rev; - break; - } + return v4l2_chip_ident_i2c_client(client, arg, state->id, state->rev); default: return -EINVAL; |