diff options
| author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-23 19:17:35 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-23 19:17:35 +0000 |
| commit | 2c81196ca33ba04ddedc0117e2bc5fb5eb92df1f (patch) | |
| tree | d8be05e7bfa1fbebf7b606ce5b27234d9ec17c52 /linux/drivers/media/video/cx88 | |
| parent | c7d13eb20a1c0b632f86d085668533d9d4440f0a (diff) | |
| download | mediapointer-dvb-s2-2c81196ca33ba04ddedc0117e2bc5fb5eb92df1f.tar.gz mediapointer-dvb-s2-2c81196ca33ba04ddedc0117e2bc5fb5eb92df1f.tar.bz2 | |
blackbird_find_mailbox negative return ignored in blackbird_initialize_codec()
From: Roel Kluin <12o3l@tiscali.nl>
dev->mailbox is unsigned. so a negative return goes unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'linux/drivers/media/video/cx88')
| -rw-r--r-- | linux/drivers/media/video/cx88/cx88-blackbird.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/linux/drivers/media/video/cx88/cx88-blackbird.c b/linux/drivers/media/video/cx88/cx88-blackbird.c index a77616c3f..0a258bfb5 100644 --- a/linux/drivers/media/video/cx88/cx88-blackbird.c +++ b/linux/drivers/media/video/cx88/cx88-blackbird.c @@ -556,10 +556,12 @@ static int blackbird_initialize_codec(struct cx8802_dev *dev) if (retval < 0) return retval; - dev->mailbox = blackbird_find_mailbox(dev); - if (dev->mailbox < 0) + retval = blackbird_find_mailbox(dev); + if (retval < 0) return -1; + dev->mailbox = retval; + retval = blackbird_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0); /* ping */ if (retval < 0) { dprintk(0, "ERROR: Firmware ping failed!\n"); |