diff options
| author | Hans Verkuil <hverkuil@xs4all.nl> | 2009-02-13 14:57:48 +0100 |
|---|---|---|
| committer | Hans Verkuil <hverkuil@xs4all.nl> | 2009-02-13 14:57:48 +0100 |
| commit | 12a53c2ca239e0fd7a2b858b577d624677982ab9 (patch) | |
| tree | b2582249f9817c2e3f4db6e6cec4f7b3f9bb5d0e /linux/drivers/media/video/saa7134 | |
| parent | 52a672f1e1c02901afbfcc810f5ab962759a05e0 (diff) | |
| download | mediapointer-dvb-s2-12a53c2ca239e0fd7a2b858b577d624677982ab9.tar.gz mediapointer-dvb-s2-12a53c2ca239e0fd7a2b858b577d624677982ab9.tar.bz2 | |
v4l2-common: add comments warning that about the sort order
From: Hans Verkuil <hverkuil@xs4all.nl>
Control arrays as are used with v4l2_ctrl_next must be sorted from
low to high. Add a comment at the top of all such arrays to warn
about this.
Priority: normal
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Diffstat (limited to 'linux/drivers/media/video/saa7134')
| -rw-r--r-- | linux/drivers/media/video/saa7134/saa7134-empress.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/linux/drivers/media/video/saa7134/saa7134-empress.c b/linux/drivers/media/video/saa7134/saa7134-empress.c index 3b0b42545..813f5f88d 100644 --- a/linux/drivers/media/video/saa7134/saa7134-empress.c +++ b/linux/drivers/media/video/saa7134/saa7134-empress.c @@ -352,6 +352,7 @@ static int empress_s_ctrl(struct file *file, void *priv, static int empress_queryctrl(struct file *file, void *priv, struct v4l2_queryctrl *c) { + /* Must be sorted from low to high control ID! */ static const u32 user_ctrls[] = { V4L2_CID_USER_CLASS, V4L2_CID_BRIGHTNESS, @@ -364,6 +365,7 @@ static int empress_queryctrl(struct file *file, void *priv, 0 }; + /* Must be sorted from low to high control ID! */ static const u32 mpeg_ctrls[] = { V4L2_CID_MPEG_CLASS, V4L2_CID_MPEG_STREAM_TYPE, |