diff options
| author | Mike Isely <isely@pobox.com> | 2006-03-30 22:16:09 -0600 |
|---|---|---|
| committer | Mike Isely <isely@pobox.com> | 2006-03-30 22:16:09 -0600 |
| commit | 012c447c3dd586921468215450cb6cce65052a3c (patch) | |
| tree | 66a65b535cc101bdfc8695981b0268885912e2f4 /linux/drivers/media/video | |
| parent | 376fb9365c967e7d2bb2aee61e01685595bf1111 (diff) | |
| download | mediapointer-dvb-s2-012c447c3dd586921468215450cb6cce65052a3c.tar.gz mediapointer-dvb-s2-012c447c3dd586921468215450cb6cce65052a3c.tar.bz2 | |
pvrusb2 driver initialization tweak
From: Mike Isely <isely@pobox.com>
Make permanent the removal of the call to pvr2_reset_ctl_endpoints().
It is known positively now that this step was both unneeded and caused
harm to communication with the hardware during driver initialization.
Signed-off-by: Mike Isely <isely@pobox.com>
Diffstat (limited to 'linux/drivers/media/video')
| -rw-r--r-- | linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 7b27d96ab..32bdaeba7 100644 --- a/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -1229,10 +1229,9 @@ static void pvr2_hdw_setup_low(struct pvr2_hdw *hdw) cptr->ctl_def->default_value); } -#if 0 // Suspect this is doing more harm than good - pvr2_reset_ctl_endpoints(hdw); - if (!pvr2_hdw_dev_ok(hdw)) return; -#endif + // Do not use pvr2_reset_ctl_endpoints() here. It is not + // thread-safe against the normal pvr2_send_request() mechanism. + // (We should make it thread safe). ret = pvr2_hdw_get_eeprom_addr(hdw); if (!pvr2_hdw_dev_ok(hdw)) return; |