diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-01-01 20:14:58 +0000 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-01-01 20:14:58 +0000 |
commit | 70a86222a3c0c15a9e2595e37134100027bb191d (patch) | |
tree | 05bf6253ee982d791c765aa69a4ad4314165f9d5 /linux/drivers/media/video | |
parent | 521fa313acab9ebc702465aff931de05d056b56d (diff) | |
download | mediapointer-dvb-s2-70a86222a3c0c15a9e2595e37134100027bb191d.tar.gz mediapointer-dvb-s2-70a86222a3c0c15a9e2595e37134100027bb191d.tar.bz2 |
Use usb_set_intfdata
From: Julia Lawall <julia@diku.dk>
This code had calls to both usb_set_intfdata and dev_set_drvdata, doing the
same thing.
The semantic patch that lead to finding this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@header@
@@
@same depends on header@
position p;
@@
usb_set_intfdata@p(...) { ... }
@depends on header@
position _p!=same.p;
identifier _f;
struct usb_interface *intf;
expression data;
@@
_f@_p(...) { <+...
- dev_set_drvdata(&intf->dev, data);
+ usb_set_intfdata(intf, data);
...+> }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'linux/drivers/media/video')
-rw-r--r-- | linux/drivers/media/video/zr364xx.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/linux/drivers/media/video/zr364xx.c b/linux/drivers/media/video/zr364xx.c index 3a409c0ff..6bd4d6a14 100644 --- a/linux/drivers/media/video/zr364xx.c +++ b/linux/drivers/media/video/zr364xx.c @@ -894,7 +894,6 @@ static void zr364xx_disconnect(struct usb_interface *intf) { struct zr364xx_camera *cam = usb_get_intfdata(intf); usb_set_intfdata(intf, NULL); - dev_set_drvdata(&intf->dev, NULL); dev_info(&intf->dev, DRIVER_DESC " webcam unplugged\n"); if (cam->vdev) video_unregister_device(cam->vdev); |