diff options
| author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2009-08-25 16:46:53 +0200 |
|---|---|---|
| committer | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2009-08-25 16:46:53 +0200 |
| commit | 9be813fc0bfdb82513f0e232f0dda18b2dba8e84 (patch) | |
| tree | d7a88ed94fa87a86dd2fc2178ae3d2fef25fe3ea /linux/drivers/media/video | |
| parent | 4eb5903e517a1d50a63f75fef61090f5f90b81ea (diff) | |
| download | mediapointer-dvb-s2-9be813fc0bfdb82513f0e232f0dda18b2dba8e84.tar.gz mediapointer-dvb-s2-9be813fc0bfdb82513f0e232f0dda18b2dba8e84.tar.bz2 | |
tw9910: do not lie about cropping abilities
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
The current tw9910 driver does not implement cropping correctly. Therefore, and
also because various rectangles in struct soc_camera_device are in user scale,
we cannot and shall not use rect_current as window location.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Priority: low
---
drivers/media/video/tw9910.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
Diffstat (limited to 'linux/drivers/media/video')
| -rw-r--r-- | linux/drivers/media/video/tw9910.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/linux/drivers/media/video/tw9910.c b/linux/drivers/media/video/tw9910.c index 29bafb3f3..852c7859f 100644 --- a/linux/drivers/media/video/tw9910.c +++ b/linux/drivers/media/video/tw9910.c @@ -719,9 +719,10 @@ static int tw9910_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *f) struct i2c_client *client = sd->priv; struct soc_camera_device *icd = client->dev.platform_data; struct v4l2_pix_format *pix = &f->fmt.pix; + /* See tw9910_set_crop() - no proper cropping support */ struct v4l2_rect rect = { - .left = icd->rect_current.left, - .top = icd->rect_current.top, + .left = 0, + .top = 0, .width = pix->width, .height = pix->height, }; @@ -850,6 +851,7 @@ static struct v4l2_subdev_ops tw9910_subdev_ops = { * i2c_driver function */ +/* This is called during probe, so, setting rect_max is Ok here: scale == 1 */ static void limit_to_scale(struct soc_camera_device *icd, const struct tw9910_scale_ctrl *scale) { |