diff options
| author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2006-08-21 10:36:36 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2006-08-21 10:36:36 -0300 |
| commit | ab3d72f8f8af39a05199d1eb2f196ebf1004de46 (patch) | |
| tree | fe01c7f8265c38be87a98fd15e4962ee12c09ab2 /linux/drivers/media/video | |
| parent | 231949a499392202fb3004873f547060cd92fadf (diff) | |
| download | mediapointer-dvb-s2-ab3d72f8f8af39a05199d1eb2f196ebf1004de46.tar.gz mediapointer-dvb-s2-ab3d72f8f8af39a05199d1eb2f196ebf1004de46.tar.bz2 | |
Fix signedness error in drivers/media/video/vivi.c
From: Eric Sesterhenn <snakebyte@gmx.de>
when checking the -Wextra signedness warnings issued by gcc 4.1
I came across this one:
drivers/media/video/vivi.c:1001: warning: comparison of unsigned expression < 0 is always false
Since videobuf_reqbufs() returns negative values on errors the current
code does no real error checking since gcc removes the comparison.
This patch fixes this issue by making ret a normal, signed integer.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'linux/drivers/media/video')
| -rw-r--r-- | linux/drivers/media/video/vivi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/linux/drivers/media/video/vivi.c b/linux/drivers/media/video/vivi.c index de72ebf74..14af7b90f 100644 --- a/linux/drivers/media/video/vivi.c +++ b/linux/drivers/media/video/vivi.c @@ -1068,7 +1068,8 @@ static int vidiocgmbuf (struct file *file, void *priv, struct video_mbuf *mbuf) struct vivi_fh *fh=priv; struct videobuf_queue *q=&fh->vb_vidq; struct v4l2_requestbuffers req; - unsigned int i, ret; + unsigned int i; + int ret; req.type = q->type; req.count = 8; |