diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-04-29 18:57:24 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-04-29 18:57:24 +0000 |
| commit | 244c2bb5a4cd825df18e2ce0ed52675943888af1 (patch) | |
| tree | e9da3aa2ad6703be687117e565a341bb64b6b3a4 /linux/drivers/media | |
| parent | a7015afafe5781e175338757b833679614e4c252 (diff) | |
| download | mediapointer-dvb-s2-244c2bb5a4cd825df18e2ce0ed52675943888af1.tar.gz mediapointer-dvb-s2-244c2bb5a4cd825df18e2ce0ed52675943888af1.tar.bz2 | |
2: modify return value of VIDIOC_REQBUFS ioctl
From: Németh Márton <nm127@freemail.hu>
The V4L2 ioctls usually return 0 when the operation was successful
and -1 in case of error. Currently VIDIOC_REQBUFS returns the
number of buffers which is redundant because this information is
available in count field of struct v4l2_requestbuffers. The
V4L2 API specification, revision 0.24 [1] explicitly specifies for
VIDIOC_REQBUFS that the return value shall be 0 on success.
The patch was tested with v4l-test 0.13 [2] with vivi driver.
References:
[1] V4L2 API specification, revision 0.24
http://v4l2spec.bytesex.org/spec/r13696.htm
[2] v4l-test: Test environment for Video For Linux Two API
http://v4l-test.sourceforge.net/
Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'linux/drivers/media')
| -rw-r--r-- | linux/drivers/media/video/videobuf-core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/linux/drivers/media/video/videobuf-core.c b/linux/drivers/media/video/videobuf-core.c index b104cd593..972f09836 100644 --- a/linux/drivers/media/video/videobuf-core.c +++ b/linux/drivers/media/video/videobuf-core.c @@ -440,6 +440,7 @@ int videobuf_reqbufs(struct videobuf_queue *q, } req->count = retval; + retval = 0; done: mutex_unlock(&q->vb_lock); |