diff options
| author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2007-07-27 11:09:57 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2007-07-27 11:09:57 -0300 |
| commit | 26cbffaaba504abd01e6378d5858b21421a3c713 (patch) | |
| tree | c9c4bac6f6a4897e62bbd4efe77758face256655 /linux/drivers/media | |
| parent | 7a6d3922decf945d9b6a2aafdeb552eba6eba8bd (diff) | |
| download | mediapointer-dvb-s2-26cbffaaba504abd01e6378d5858b21421a3c713.tar.gz mediapointer-dvb-s2-26cbffaaba504abd01e6378d5858b21421a3c713.tar.bz2 | |
Dvb-usb/af9005-fe.c: error check fixes
From: Adrian Bunk <bunk@stusta.de>
This patch:
- adds a missing error check and
- removes an error check that could never be true
Both spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Luca Olivetti <luca@ventoso.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'linux/drivers/media')
| -rw-r--r-- | linux/drivers/media/dvb/dvb-usb/af9005-fe.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/linux/drivers/media/dvb/dvb-usb/af9005-fe.c b/linux/drivers/media/dvb/dvb-usb/af9005-fe.c index f33f15dde..a2c8397b9 100644 --- a/linux/drivers/media/dvb/dvb-usb/af9005-fe.c +++ b/linux/drivers/media/dvb/dvb-usb/af9005-fe.c @@ -343,8 +343,8 @@ static int af9005_reset_pre_viterbi(struct dvb_frontend *fe) 1 & 0xff); if (ret) return ret; - af9005_write_ofdm_register(state->d, xd_p_fec_super_frm_unit_15_8, - 1 >> 8); + ret = af9005_write_ofdm_register(state->d, xd_p_fec_super_frm_unit_15_8, + 1 >> 8); if (ret) return ret; /* reset pre viterbi error count */ @@ -908,10 +908,8 @@ static int af9005_fe_init(struct dvb_frontend *fe) af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst, reg_ofdm_rst_pos, reg_ofdm_rst_len, 1))) return ret; - if ((ret = - af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst, - reg_ofdm_rst_pos, reg_ofdm_rst_len, 0))) - return ret; + ret = af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst, + reg_ofdm_rst_pos, reg_ofdm_rst_len, 0); if (ret) return ret; |