summaryrefslogtreecommitdiff
path: root/linux/drivers/media
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@redhat.com>2009-02-08 09:42:29 -0200
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-02-08 09:42:29 -0200
commitcde88dd58c4b1be925590b3b7f8d454cfd0d7441 (patch)
tree8382daba2a5d3570c45870a52d3e80a93d78328d /linux/drivers/media
parentca4755f6e3b59333a7d5df3b7808d785bfb006b1 (diff)
downloadmediapointer-dvb-s2-cde88dd58c4b1be925590b3b7f8d454cfd0d7441.tar.gz
mediapointer-dvb-s2-cde88dd58c4b1be925590b3b7f8d454cfd0d7441.tar.bz2
tda8290: Print an error if i2c_gate is not provided
From: Mauro Carvalho Chehab <mchehab@redhat.com> While here, be sure that gate will be kept disabled if an error occurs. Priority: normal CC: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'linux/drivers/media')
-rw-r--r--linux/drivers/media/common/tuners/tda8290.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/linux/drivers/media/common/tuners/tda8290.c b/linux/drivers/media/common/tuners/tda8290.c
index 67c0fd5f7..54423df4c 100644
--- a/linux/drivers/media/common/tuners/tda8290.c
+++ b/linux/drivers/media/common/tuners/tda8290.c
@@ -589,8 +589,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)
u8 data;
struct i2c_msg msg = { .flags = I2C_M_RD, .buf = &data, .len = 1 };
- if (NULL == analog_ops->i2c_gate_ctrl)
+ if (!analog_ops->i2c_gate_ctrl) {
+ printk(KERN_ERR "tda8290: no gate control were provided!\n");
+
return -EINVAL;
+ }
analog_ops->i2c_gate_ctrl(fe, 1);
@@ -638,6 +641,7 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)
if (ret != 1) {
tuner_warn("tuner access failed!\n");
+ analog_ops->i2c_gate_ctrl(fe, 0);
return -EREMOTEIO;
}