diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-09-16 01:24:29 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-09-16 01:24:29 +0000 |
| commit | 1252343c32470785b0e37b5736ce4064f8af3506 (patch) | |
| tree | 1f34124f88a4572140a52389b132bce016ddfa1a /linux/drivers | |
| parent | c4cf46815549e8414d732d62f7d1deaf5a97473d (diff) | |
| download | mediapointer-dvb-s2-1252343c32470785b0e37b5736ce4064f8af3506.tar.gz mediapointer-dvb-s2-1252343c32470785b0e37b5736ce4064f8af3506.tar.bz2 | |
uvcvideo: Fix incomplete frame drop when switching to a variable size format.
From: Laurent Pinchart <laurent.pinchart@skynet.be>
When streaming in a fixed size format the driver sets a flag in the uvc_queue
structure to drop incomplete incoming frames. The flag wasn't cleared when
switching to a variable size format, which resulted in a broken
'MJPEG after YUV'.
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'linux/drivers')
| -rw-r--r-- | linux/drivers/media/video/uvc/uvc_v4l2.c | 4 | ||||
| -rw-r--r-- | linux/drivers/media/video/uvc/uvc_video.c | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/linux/drivers/media/video/uvc/uvc_v4l2.c b/linux/drivers/media/video/uvc/uvc_v4l2.c index d4758c8e1..78e4c4e09 100644 --- a/linux/drivers/media/video/uvc/uvc_v4l2.c +++ b/linux/drivers/media/video/uvc/uvc_v4l2.c @@ -842,10 +842,6 @@ static int uvc_v4l2_do_ioctl(struct inode *inode, struct file *file, if (ret < 0) return ret; - if (!(video->streaming->cur_format->flags & - UVC_FMT_FLAG_COMPRESSED)) - video->queue.flags |= UVC_QUEUE_DROP_INCOMPLETE; - rb->count = ret; ret = 0; break; diff --git a/linux/drivers/media/video/uvc/uvc_video.c b/linux/drivers/media/video/uvc/uvc_video.c index 593aebffe..b7bb23820 100644 --- a/linux/drivers/media/video/uvc/uvc_video.c +++ b/linux/drivers/media/video/uvc/uvc_video.c @@ -971,6 +971,11 @@ int uvc_video_enable(struct uvc_video_device *video, int enable) return 0; } + if (video->streaming->cur_format->flags & UVC_FMT_FLAG_COMPRESSED) + video->queue.flags &= ~UVC_QUEUE_DROP_INCOMPLETE; + else + video->queue.flags |= UVC_QUEUE_DROP_INCOMPLETE; + if ((ret = uvc_queue_enable(&video->queue, 1)) < 0) return ret; |